Tweak code signing lanes naming and make them all public #23991

mokagio · 2025-01-20T04:24:24Z

This was done in the context of regenerating soon expiring certificates, see pdnsEh-1ZG-p2

I tweaked the name to be hierarchical. That is, the lane that updates everything is update_certs_and_profiles, the lane that updates all the WordPress variants is update_certs_and_profiles_wordpress, the lane that update only the WordPress App Store variant is update_certs_and_profiles_wordpress_app_store.

I also made all lanes public, so they can be called individually, and added new lanes for updating both app's App Store or Enterprise code siging.

Testing

I run these locally as part of the certificates update work.

Regression Notes

Potential unintended areas of impact – N.A.
What I did to test those areas of impact (or what existing automated tests I relied on) – N.A.
What automated tests I added (or what prevented me from doing so) – N.A.

PR submission checklist:

I have completed the Regression Notes.
I have considered adding unit tests for my changes. N.A.
I have considered adding accessibility improvements for my changes. N.A.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary. N.A.

UI changes testing checklist: Not a UI PR.

This way, we can better code complete

Full name `update_certs_and_profiles_wordpress_enterprise`

Full name `update_certs_and_profiles_wordpress_app_store`

Full name `update_certs_and_profiles_jetpack_enterprise`

Full name `update_certs_and_profiles_jetpack_app_store`

This way, we can call them when it's time to regenerate the profiles for one single combination without hacking the `Fastfile`.

This will avoid API redirects

wpmobilebot · 2025-01-20T04:37:36Z

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr23991-b10ce3e
	Version	25.6
	Bundle ID	org.wordpress.alpha
	Commit	`b10ce3e`
	App Center Build	WPiOS - One-Offs #11374

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot · 2025-01-20T04:38:20Z

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr23991-b10ce3e
	Version	25.6
	Bundle ID	com.jetpack.alpha
	Commit	`b10ce3e`
	App Center Build	jetpack-installable-builds #10407

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

iangmaia

👍

iangmaia · 2025-01-21T12:16:09Z

fastlane/lanes/codesign.rb

@@ -126,6 +142,7 @@ def update_code_signing(type:, team_id:, readonly:, app_identifiers:, api_key_pa
  match(
    storage_mode: 's3',
    s3_bucket: 'a8c-fastlane-match',
+    s3_region: 'us-east-2',


Perhaps we could use here the same storage options constant you added on Woo.

Thanks! Addressed in b10ce3e

Maybe we could also push that constant in release-toolkit, to guarantee it's the same across projects. And the same could be done for sets of env vars that we check here and there.

iangmaia · 2025-01-21T12:22:09Z

fastlane/lanes/codesign.rb

@@ -126,6 +142,7 @@ def update_code_signing(type:, team_id:, readonly:, app_identifiers:, api_key_pa
  match(


Also after seeing https://github.com/woocommerce/woocommerce-ios/pull/14911/files#diff-dff4b99d4e651ab9d7597876ec8dbe92aa934e42c0fb55f4aadd6c106fc96688R1153, I wonder if we should try and use a consistent name (match / sync_code_signing) across projects 🤔

Great point @iangmaia !

I clearly missed that this was called via match, otherwise I would have updated it to sync_code_signing like I've done elsewhere. But since you raised the question, I thought I'd bubble it up internally to have an official discussion about team's preferences: paaHJt-7Je-p2

I clicked the "Merge when ready" without addressing this suggestion. I just want to wait and see what the outcome of the discussion is. Given I linked to here in the discussion, I'll be able to followup what that has taken place.

Next step... move the constant to release toolkit?

mokagio added 9 commits January 20, 2025 14:59

Use block named parameters in code signing lanes

3d624ea

Use hierarchical names in code signing lanes

a87db72

This way, we can better code complete

Rename alpha_code_sign to ..._wordpress_enterprise

e185633

Full name `update_certs_and_profiles_wordpress_enterprise`

Rename appstore_code_sign to ..._wordpress_app_store

4a441ea

Full name `update_certs_and_profiles_wordpress_app_store`

Rename jetpack_alpha_code_sign to ..._jetpack_enterprise

b724af0

Full name `update_certs_and_profiles_jetpack_enterprise`

Rename jetpack_appstore_code_sign to ..._jetpack_app_store

c403072

Full name `update_certs_and_profiles_jetpack_app_store`

Make app-x-account specific code sign lanes public

bf2579f

This way, we can call them when it's time to regenerate the profiles for one single combination without hacking the `Fastfile`.

Add lanes code signing lanes to Enterprise and App Store only combos

9861465

Configure code signing bucket s3_region to us-east-2

4fac6d8

This will avoid API redirects

mokagio requested a review from a team January 20, 2025 04:24

mokagio self-assigned this Jan 20, 2025

mokagio added the Tooling Build, Release, and Validation Tools label Jan 20, 2025

mokagio added this to the Pending milestone Jan 20, 2025

mokagio marked this pull request as ready for review January 20, 2025 04:25

This was referenced Jan 20, 2025

Tweak code signing lanes naming and make them all public woocommerce/woocommerce-ios#14911

Merged

Tweak code signing lanes naming and make them all public Automattic/simplenote-ios#1693

Merged

iangmaia approved these changes Jan 21, 2025

View reviewed changes

iangmaia reviewed Jan 21, 2025

View reviewed changes

Extract code signing S3 settings in constant

b10ce3e

Next step... move the constant to release toolkit?

mokagio enabled auto-merge January 21, 2025 18:55

mokagio added this pull request to the merge queue Jan 21, 2025

Merged via the queue into trunk with commit 4546518 Jan 21, 2025
25 checks passed

mokagio deleted the mokagio/public_match_lanes branch January 21, 2025 19:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tweak code signing lanes naming and make them all public #23991

Tweak code signing lanes naming and make them all public #23991

mokagio commented Jan 20, 2025

wpmobilebot commented Jan 20, 2025 •

edited

Loading

wpmobilebot commented Jan 20, 2025 •

edited

Loading

iangmaia left a comment

iangmaia Jan 21, 2025

mokagio Jan 21, 2025

iangmaia Jan 21, 2025

mokagio Jan 21, 2025

mokagio Jan 21, 2025

		@@ -126,6 +142,7 @@ def update_code_signing(type:, team_id:, readonly:, app_identifiers:, api_key_pa
		match(

Tweak code signing lanes naming and make them all public #23991

Tweak code signing lanes naming and make them all public #23991

Conversation

mokagio commented Jan 20, 2025

Testing

Regression Notes

wpmobilebot commented Jan 20, 2025 • edited Loading

wpmobilebot commented Jan 20, 2025 • edited Loading

iangmaia left a comment

Choose a reason for hiding this comment

iangmaia Jan 21, 2025

Choose a reason for hiding this comment

mokagio Jan 21, 2025

Choose a reason for hiding this comment

iangmaia Jan 21, 2025

Choose a reason for hiding this comment

mokagio Jan 21, 2025

Choose a reason for hiding this comment

mokagio Jan 21, 2025

Choose a reason for hiding this comment

wpmobilebot commented Jan 20, 2025 •

edited

Loading

wpmobilebot commented Jan 20, 2025 •

edited

Loading