task: Remote feature flag gates GutenbergKit #24465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow remote control of GutenbergKit roll out.
Collaborator
Generated by 🚫 Danger |
|
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 27374 | |
| Version | PR #24465 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 1f9dd27 | |
| Installation URL | 5sm150mg3600g |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 27374 | |
| Version | PR #24465 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 1f9dd27 | |
| Installation URL | 6ptb45mkiehj8 |
kean
approved these changes
Apr 16, 2025
Contributor
kean
left a comment
kean
left a comment
There was a problem hiding this comment.
(removed the previous question)
dcalhoun
added a commit
that referenced
this pull request
Apr 17, 2025
This conditional was overlooked when the local experimental feature toggle was augmented with a remote feature flag for roll out control. #24465
dcalhoun
added a commit
that referenced
this pull request
Apr 24, 2025
This conditional was overlooked when the local experimental feature toggle was augmented with a remote feature flag for roll out control. #24465
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 24, 2025
* hoist settings * refactor: Update settings via JavaScript bridge * fix: Fetch the entirety of the editor settings * Revert "refactor: Update settings via JavaScript bridge" This reverts commit e4ec71b6c77e2439e9d98c0273f9bdcff64d098f. * feat: Postpone editor initialization * Revert "feat: Postpone editor initialization" This reverts commit 39ac9caf71089853e5f256697f4882cc55d2bffd. * refactor: Defer editor start * refactor: Simplify RawBlockEditorSettingsService Remove unnecessary completion handler structure. * feat: Cache editor settings fetch Improve editor start performance. * feat: Editor settings use stale-while-revalidate cache Mitigate stale editor settings. * style: Use shorthand * feat: Cache editor settings across editor sessions The cache was discarded each time the editor closed, which defeats the purpose of the cache. We must store it somewhere outside the editor view controller. * refactor: Avoid duplicative settings requests Avoid sending both foreground and background requests. * feat: Remove time-based cache Revalidating the cache on each editor launch will ensure the latest settings are available. * build: Update GutenbergKit ref * build: Update GutenbergKit ref * build: Update GutenbergKit ref * build: Update GutenbergKit ref * perf: Preload editor settings within My Site Improve load speed of editor. * fix: Enable GutenbergKit warmup via remote feature flag This conditional was overlooked when the local experimental feature toggle was augmented with a remote feature flag for roll out control. #24465 * feat: Start editor without settings after three seconds Avoid postponing the editor start for longer than three seconds. We instead present the editor without any site-specific settings. * refactor: DRY up fetching editor settings * build: Update GutenbergKit ref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Augment the existing, user-controlled experimental feature toggle with a remote feature flag that can we used for a phased roll out GutenbergKit regardless of the experimental feature toggle state.
To test: A remote feature flag has not yet been deployed on the server, so there should be no changes to the UX.
Regression Notes
Unlikely for this addition.
N/A.
Deemed unnecessary for the experimental feature.
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: