-
Notifications
You must be signed in to change notification settings - Fork 8
Implements latest post summary in Insights #315
Implements latest post summary in Insights #315
Conversation
Conflicts: WordPressCom-Stats-iOS/InsightsTableViewController.m
Updated the Travis build with this fix to let xctool actually run the unit tests properly - facebookarchive/xctool#528 (comment) |
StatsDemo build 39 has this PR included. |
switch (indexPath.row) { | ||
case 1: // Views | ||
{ | ||
cell.categoryIconLabel.text = @""; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is me not mentioning how fragile the
looks like!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know, I KNOW 😄
Not sure exactly why, but i'm seeing this in the Console logs (Xcode 7):
|
@astralbodies I've got a post with 0 likes and 0 comments (plus a bunch views). Tapping over any of the rows always leads to the same details view, would that be expected? |
And yet another comment (sorry about the spam!). The Post Summary's Details view shows the Post Title within the View Controller's It's way too easy to get that string clipped. Comment / suggestion, would it be possible to perhaps reuse the This is how my last post looks like: |
Re: tapping the rows in the insights getting to the same post details - that is correct behavior for right now. I did open another issue for the post details title in the navigation bar. Thanks for reviewing @jleandroperez. I need to make the view controllers smaller and it is on my radar soon. :stabby: ? |
Thanks for checking @astralbodies! |
…st-post-summary Implements latest post summary in Insights
@astralbodies great job adding this module to Insights! 2 minor comments :)
|
Thanks @jancavan - I'll make this another issue 👍 |
Closes #289
New UI:
Test scenarios:
How to test:
Needs Review: @jancavan, @jleandroperez, @daniloercoli