Skip to content

Commit

Permalink
Inline .podspec.json extension definition
Browse files Browse the repository at this point in the history
I noticed this because RuboCop barked at me for having a method with 11
SLOC instead of 10.

However, I'm happy with the change. The implementation expects the file
to be a JSON, so there's little value in making the extension
configurable. If we changed that var to `.podspec`, the implementation
would break!
  • Loading branch information
mokagio committed Sep 15, 2023
1 parent 5fe3b77 commit 8f9fb1c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
4 changes: 1 addition & 3 deletions ios-xcframework/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,7 @@ def setup_rnreanimated_pod_from_fork
end

def gutenberg_dependencies
podspec_extension = '.podspec.json'

Dir["../third-party-podspecs/*#{podspec_extension}"].each do |podspec_path|
Dir['../third-party-podspecs/*.podspec.json'].each do |podspec_path|
pod_name = JSON.parse(File.read(podspec_path))['name']

raise "Could not find pod name in JSON spec at #{podspec_path}" unless pod_name
Expand Down
2 changes: 1 addition & 1 deletion ios-xcframework/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -665,6 +665,6 @@ SPEC CHECKSUMS:
WordPress-Aztec-iOS: 7d11d598f14c82c727c08b56bd35fbeb7dafb504
Yoga: f7decafdc5e8c125e6fa0da38a687e35238420fa

PODFILE CHECKSUM: eed59291e8f65f4e532304d8e4091728b1906889
PODFILE CHECKSUM: a240fb0d100c639b9b0bcedab219f9b0b51fbf0a

COCOAPODS: 1.12.1

0 comments on commit 8f9fb1c

Please sign in to comment.