-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Buttons block #1790
Comments
Hello @pinarol @iamthomasbishop, before starting
|
Awesome to see this so quickly!
I think they should probably be displayed inline (side-by-side), yes.
I think the appender could be displayed inline as well, right next to the buttons (assuming that's where the button is created, as mentioned above.
I wonder if we should skip the inserter flow altogether when a new button is added. What I mean is the button could be added immediately when the appender is tapped, no need for the inserter sheet and "add block here" indicator.
I think this is fine. We're borrowing the icon from core, so I think we should only change it if they also change the icon.
Yes, see my note above (in the third comment). |
@lukewalczak Could you check web's behavior about this? It'd be enough if we only wrap the buttons and let them break into the next line once they don't fit the current line anymore, flex-box should handle it. I expect we won't need to make extra calculations about min or max width if I am not wrong. |
Sure, will check it, however, it was just a quick idea.
@iamthomasbishop How should appender look like then? Should it take the whole free space next to the last button? |
Cool, That's exactly what I had in mind 👍 |
I was assuming this would be the best way to go with Buttons, until I start thinking about individual Button alignments. I couldn't imagine how to demonstrate alignment of each Button there. @iamthomasbishop wdyt? The first thing that comes to my mind is stacking each button vertically instead, that way we'd be able to demonstrate horizontal alignments. |
@pinarol Considering the Buttons block has a control for alignment, which aligns the "group" of blocks, I think we should exclude the alignment controls on each of the inner buttons and let the parent Buttons block control the list of buttons. It's not only clunky when you attempt to align individual buttons within a parent Buttons block, but it's also a bit confusing. With that said, here's an example of what I'm thinking in terms of child block alignments (along with the appender): Note: this example is also showing how wrapping would work. |
@iamthomasbishop That looks super good 👍and I agree all. I thought since it is available on web we should look for ways to support it as well. But I agree that we'll have a better UX excluding it. Thanks! |
@iamthomasbishop I would like to ask one more question into |
I think I would expect it to act like a group as well. In other words, after deleting the last button, the Buttons block would essentially revert to the placeholder/starter state, where the parent (Buttons) block is selected and only the appender button is shown inside. |
How should the placeholder look like when |
Ahh, that’s a good question. After thinking about it, I think perhaps we should do one of the following two things:
I am leaning towards the first option, because I think it would feel more fluid and expected — if I’m tapping delete, I would expect it to delete the thing (in this case, the only child Button and the parent Buttons block). |
I've implemented the first solution! Thanks @iamthomasbishop! |
Add mobile equivalent of Buttons block.
The text was updated successfully, but these errors were encountered: