Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPT] Design feedback issues #2012

Closed
5 tasks done
koke opened this issue Mar 13, 2020 · 4 comments · Fixed by #2027
Closed
5 tasks done

[SPT] Design feedback issues #2012

koke opened this issue Mar 13, 2020 · 4 comments · Fixed by #2027
Assignees

Comments

@koke
Copy link
Member

koke commented Mar 13, 2020

Collecting here a list of design tweaks from WordPress/gutenberg#20718

  • Can we add ~12px of padding at the top of the page content? I believe we are applying additional padding on top of the post/page title in the editor, so this would align with that (example: https://cloudup.com/cbMvzmdHb6a)
  • The App Bar seems a bit too tall compared to the native one (~9 or 10px too tall). Can we shorten it up slightly to align more with the native one? I believe 56px tall should work across platforms (example: https://cloudup.com/c-hVuBGgeVv)
  • [iOS] Dark Mode: border-bottom on the navigation bar is a bit too strong. We can probably dim it down a bit?
  • [iOS] Dark Mode: I wonder if we should apply a dark gray bg on the Navigation Bar to match the native one.
  • Can we apply a 300ms fadeOut to the inline picker buttons when they disappear?

it's not anything critical, but it may be a nice little improvement if it doesn't require a bunch of work

@koke
Copy link
Member Author

koke commented Mar 13, 2020

border-bottom on the navigation bar is a bit too strong. We can probably dim it down a bit?
we should apply a dark gray bg on the Navigation Bar to match the native one.

@iamthomasbishop can you give me specific values for these two?

@iamthomasbishop
Copy link
Contributor

iamthomasbishop commented Mar 13, 2020

can you give me specific values for these two?

Sure can!

(Note: iOS dark-mode only)

  • Navigation Bar background: It would be worth x-referencing with WPiOS to see what value they're using because I don't believe they're using the translucent materials. If we can't, we can use #1E1E1E, which is almost exactly the iOS system-defined "Primary" elevated gray for dark mode used for Navigation Bars.

  • Navigation Bar border-bottom: Same suggestion as ⬆️ , let's use the same value as WPiOS if possible, otherwise we can use #2D2D2D.

@koke
Copy link
Member Author

koke commented Mar 16, 2020

It would be worth x-referencing with WPiOS to see what value they're using because I don't believe they're using the translucent materials

It doesn't seem translucent but the color I'm seeing is #0f1518

@iamthomasbishop
Copy link
Contributor

It doesn't seem translucent but the color I'm seeing is #0f1518

That should work fine 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants