Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Starter Page Templates - Picker and Preview design updates #2027

Merged
merged 7 commits into from
Mar 27, 2020
Merged

Starter Page Templates - Picker and Preview design updates #2027

merged 7 commits into from
Mar 27, 2020

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Mar 17, 2020

Fixes #2012

Gutenberg PR -> WordPress/gutenberg#20959

To test check Gutenberg PR description

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@geriux geriux mentioned this pull request Mar 17, 2020
Merged
6 tasks
@geriux geriux requested review from mkevins and koke March 18, 2020 08:38
@geriux
Copy link
Contributor Author

geriux commented Mar 18, 2020

Hey 👋 @koke @mkevins =)

I've just added you as reviewers for this PR, I was thinking maybe @mkevins could test on Android and @koke on iOS? Let me know if you have some time if not I could reassign.

Thank you!

@geriux geriux mentioned this pull request Mar 23, 2020
Closed
3 tasks
@geriux geriux force-pushed the feature/spt-picker-preview-design-improvements branch from dd41675 to 83a3faf Compare March 26, 2020 15:17
@geriux geriux merged commit 6404377 into develop Mar 27, 2020
@geriux geriux deleted the feature/spt-picker-preview-design-improvements branch March 27, 2020 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koke koke koke approved these changes

@mkevins mkevins Awaiting requested review from mkevins

Assignees
No one assigned
Labels
Page Templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SPT] Design feedback issues
2 participants
@geriux @koke