Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page Templates: difficult to access content area in landscape mode on smaller devices #2088

Closed
designsimply opened this issue Mar 31, 2020 · 8 comments · Fixed by #2123
Closed
Assignees
Labels
[OS] iOS [Type] Bug Something isn't working

Comments

@designsimply
Copy link
Contributor

Describe the bug

It's difficult to access the content area for editing pages in landscape mode on small devices because the page templates icons overlap with it.

To Reproduce

  1. Go to My Sites > Pages > +.
  2. Rotate the device to landscape mode.
  3. Try to tap on the "Start writing…" prompt in the default first block.

Expected behavior

I expect that I should be able to tap on the default first paragraph block without interference, but the page templates overlap with the first block and it's hard to access it.

Screenshots

The problem is even more prevalent on small device screens.

IMG_3593

Smartphone (please complete the following information):

  • Device: iPhone 6S
  • OS: iOS 13.3.1
  • Version: WPiOS 14.5.0.1 TestFlight beta
@designsimply designsimply added [Type] Bug Something isn't working [OS] iOS labels Mar 31, 2020
@geriux
Copy link
Contributor

geriux commented Apr 1, 2020

Thanks for opening this issue @designsimply =)

There were some feedback discussions about this but I don't think any decisions were made.

The current status on 14.6 will be the same but without that transparency:

Simulator Screen Shot - iPhone 6s - 2020-04-01 at 10 57 34

@pinarol 👋 you mentioned:

I thought this was already discussed when we dropped the first design which had the buttons under the paragraph block

Should we move these buttons to be under the first paragraph block? cc @iamthomasbishop

@iamthomasbishop
Copy link
Contributor

Should we move these buttons to be under the first paragraph block? cc @iamthomasbishop

In landscape, perhaps. Or we could also hide the keyboard when the user first lands on or rotates to landscape. On portrait, I would keep as-is if possible, as that seems to be working well.

@geriux
Copy link
Contributor

geriux commented Apr 3, 2020

Or we could also hide the keyboard when the user first lands on or rotates to landscape.

I like this option better and it'd be easier than to switch the position of the picker depending on the orientation.

@iamthomasbishop
Copy link
Contributor

@geriux Cool, let’s roll with that then. Do you think we should also fade out the buttons when the keyboard comes back in? (And fade back in when the keyboard is hidden?)

@pinarol
Copy link
Contributor

pinarol commented Apr 3, 2020

I think we can put a smarter mechanism like:

  • if the keyboard is closed: Display the template picker buttons normally
  • if the keyboard is open: Check if window height is enough(detect a good enough threshold), if not, just hide the buttons.

Or we could also hide the keyboard when the user first lands on or rotates to landscape.

This would effect all writing flow not just the one with template picker buttons so I'd avoid doing that.
Also, we don't need to hide it for iPads.

@geriux
Copy link
Contributor

geriux commented Apr 6, 2020

Sounds good @pinarol!

@geriux geriux self-assigned this Apr 6, 2020
@iamthomasbishop
Copy link
Contributor

@pinarol

if the keyboard is open: Check if window height is enough(detect a good enough threshold), if not, just hide the buttons.

This would def be good 👍

This would effect all writing flow not just the one with template picker buttons so I'd avoid doing that. Also, we don't need to hide it for iPads.

Yea, I definitely wouldn't hide the keyboard on iPad — only on phone in landscape phone because of lack of real estate. The overall landscape writing experience could probably be an entire separate project, so for now, simply hiding the SPTs inline picker on landscape phone sounds good to me.

@wptester9845
Copy link

This issue has also been observed on the iPhone X (12.3.1) using WordPress 14.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[OS] iOS [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants