Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout Picker - Keyboard visibility improvements #2123

Merged
merged 5 commits into from
Apr 8, 2020

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Apr 7, 2020

Fixes #2088

Gutenberg PR -> WordPress/gutenberg#21463

To test check the Gutenberg PR description.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 8, 2020

You can trigger optional full suite of UI tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can trigger optional full suite of UI tests for these changes by visiting CircleCI here.

Copy link
Contributor

@chipsnyder chipsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 Approved via WordPress/gutenberg#21463 (review)

@geriux geriux merged commit c5d485a into develop Apr 8, 2020
@geriux geriux deleted the feature/layout-picker-keyboard branch April 8, 2020 14:20
@pinarol pinarol added this to the 1.26 milestone Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page Templates: difficult to access content area in landscape mode on smaller devices
3 participants