Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make createBlockAction create a block instead of carrying a model #271

Closed
2 tasks
mzorz opened this issue Nov 22, 2018 · 2 comments
Closed
2 tasks

Make createBlockAction create a block instead of carrying a model #271

mzorz opened this issue Nov 22, 2018 · 2 comments
Labels
[Type] Enhancement Improves a current area of the editor
Milestone
Beta

Comments

@mzorz
Copy link
Contributor

mzorz commented Nov 22, 2018 •
edited by koke
Loading

Originally in #58, moved here as this is a nice to have:

  • make createBlockAction actually create a block instead of carry a block model and insert it in the list (Inserter - basic support for block addition #88 (comment))
  • after this one above (createBlockAction change), enhance the CREATE_BLOCK action tests to run through all registered blocks and create each one, verifying the expected block type has been created

Estimated 1 week
@mzorz mzorz added the [Type] Enhancement Improves a current area of the editor label Nov 22, 2018
@mzorz mzorz added this to the Beta milestone Nov 22, 2018
@koke
Copy link
Member

koke commented Jan 16, 2019

I don't fully understand this one, is this still necessary after the store changes?

@mzorz
Copy link
Contributor Author

mzorz commented Jan 16, 2019

Probably not, closing this

@mzorz mzorz closed this as completed Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Type] Enhancement Improves a current area of the editor
Projects
None yet
Milestone
Beta
Development

No branches or pull requests
2 participants
@koke @mzorz