-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inserter #58
Comments
Adding rough design draft for v1 here: This is how I plan to approach this: State management / basic flow
Navigation / Bottom sheet work
I believe this iterative approach will lead us to better understand the needs in each phase, and we'll be better prepared for iteration #4 to actually create the component out of the things we've found out to be useful/needed in the other iterations |
Headsup @mzorz , I went ahead and struck out iteration No4 in #58 (comment) as I think it should not block the feature completion and it can be performed at a future point in time. |
I updated the description for this one. @mzorz do you think I missed anything in the alpha requirements? Can you take a look at estimations since it looks like you already have a good idea of what needs to be done? |
Focus handlingWhile not directly related to the Inserter, it's of basic need that the focus state and UI representation gets handled right when inserting / moving blocks / switching focus.
Integration with toolbar
Other (code)
Other (UI)
EstimationsMy rough thoughts on this are:
|
Definitely feel free to move that there 👍 |
I ended up grouping the focus issues in #196 and crossed them out of the list here |
I came across a couple good looking (native, iOS) libraries for the bottom sheet, so I'll leave them here in case they're useful in the future: |
…s-for-gb Disable Aztec plugins by default since we don't need them on GB mobile
Moved the task list and estimations to the description, please make sure to update it there as we make progress |
Moved the remaining UI pass to #349 for the Beta |
Add an insert button that shows a list of registered blocks, and adds the selected block after the currently focused block.
Requirements for alpha:
Tasks
Integration with toolbar (2 weeks)
+
adder control placeholder (to be connected to the toolbar)Other (1 week)
The text was updated successfully, but these errors were encountered: