-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/inserter modal #124
Conversation
👋@mzorz, can we use the "Scrollable modal" half-height example from the That should get us closer to the designs for the Inserter. Any background info perhaps on why we need to do the full screen modal first? |
sure thing @hypest ! Was planning on focusing on making it look as we want tomorrow. This only is for the moment a first rough attempt that I wanted to put on the repo to make progress visible as I perform work on it, just for reference. That's why I marked this PR Will remove the label and ping reviewers once it's ready for review 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see the translucent background sliding in 😁
But it looks amazing for a first iteration 👏 🍾 🥂
Me too 😉 hehe there's still tweaks needed, we'll get to nail all those details soon 👍 Thanks for your review&merge @koke ! |
Just wanted to comment here that I ❤️ how this work on the Inserter has progressed! Good job @mzorz ! |
UPDATE: this PR is ready for review now.
This PR adds a new
BlockPicker
component that shows the list of available (registered) blocks on aFlatList
using the modal libraryreact-native-modal
.ToDo
BlockType
fromdashicons
will be done once Implement toolbar on React Native WordPress/gutenberg#9012 and Feature/toolbar #117 get mergedUpdated gif