Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/inserter modal #124

Merged
merged 23 commits into from
Aug 23, 2018
Merged

Feature/inserter modal #124

merged 23 commits into from
Aug 23, 2018

Conversation

mzorz
Copy link
Contributor

@mzorz mzorz commented Aug 20, 2018

UPDATE: this PR is ready for review now.

This PR adds a new BlockPicker component that shows the list of available (registered) blocks on a FlatList using the modal library react-native-modal.

  • First blocks and action/props connectivity is in place
  • worked a bit on styles, to make a better match (though not final) to what the designs show in Inserter #58
  • a new "ADD BLOCK HERE" label is shown when the picker is shown, to hint the user about where the block insertion is going to happen

screenshot_1534964690 copy

ToDo

Updated gif
insertermodal3

@mzorz mzorz mentioned this pull request Aug 20, 2018
4 tasks
@hypest
Copy link
Contributor

hypest commented Aug 20, 2018

👋@mzorz, can we use the "Scrollable modal" half-height example from the react-native-modal as demonstrated in https://raw.githubusercontent.com/mmazzarolo/react-native-modal/master/.github/example-modal.gif (last one on the gif)?

That should get us closer to the designs for the Inserter. Any background info perhaps on why we need to do the full screen modal first?

@mzorz
Copy link
Contributor Author

mzorz commented Aug 21, 2018

👋@mzorz, can we use the "Scrollable modal" half-height example

sure thing @hypest ! Was planning on focusing on making it look as we want tomorrow. This only is for the moment a first rough attempt that I wanted to put on the repo to make progress visible as I perform work on it, just for reference. That's why I marked this PR not ready for review in the first place 😉

Will remove the label and ping reviewers once it's ready for review 👍

@mzorz
Copy link
Contributor Author

mzorz commented Aug 22, 2018

Still a long way to go (not ready for review yet), but here's the modal anchored to the bottom:

insertermodal2

@daniloercoli daniloercoli self-assigned this Aug 23, 2018
Copy link
Member

@koke koke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the translucent background sliding in 😁
But it looks amazing for a first iteration 👏 🍾 🥂

@koke koke merged commit 469a718 into master Aug 23, 2018
@koke koke deleted the feature/inserter-modal branch August 23, 2018 07:03
@mzorz
Copy link
Contributor Author

mzorz commented Aug 23, 2018

I can see the translucent background sliding in 😁

Me too 😉 hehe there's still tweaks needed, we'll get to nail all those details soon 👍

Thanks for your review&merge @koke !

@hypest
Copy link
Contributor

hypest commented Sep 6, 2018

Just wanted to comment here that I ❤️ how this work on the Inserter has progressed! Good job @mzorz !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants