Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserter - added direct insertion to block manager #96

Conversation

mzorz
Copy link
Contributor

@mzorz mzorz commented Aug 8, 2018

This PR builds on top of #95, and adds direct insertion at a specific index in the list state. For the sake of the exercise in the GB mobile application for now we're inserting right below the tapped block.

Before, it would only append new blocks to the list.

Android

insertertake1direct

iOS

insertertake1direct_ios

@mzorz mzorz mentioned this pull request Aug 8, 2018
4 tasks
@hypest
Copy link
Contributor

hypest commented Aug 14, 2018

With #95 closed, I think it makes sense to target this one against feature/inserter directly? WDYT @mzorz ?

@mzorz
Copy link
Contributor Author

mzorz commented Aug 14, 2018

Closing in favor of #110

@mzorz mzorz closed this Aug 14, 2018
@mzorz mzorz deleted the try/inserter-take1-state-props-direct-insert branch August 16, 2018 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants