Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed block: Inline preview is enabled for Pinterest URLs and is not properly rendered #3983

Open
fluiddot opened this issue Sep 17, 2021 · 1 comment
Labels
Embed block [Type] Bug Something isn't working

Comments

@fluiddot
Copy link
Contributor

Describe the bug
Pinterest provider is not supported in the Embed block so the inline preview shouldn't be enabled, however, since it's being rendered as a WordPress embed it's not being filtered out and therefore it's being displayed.

Related code:
https://github.com/WordPress/gutenberg/blob/aa6217fc2a81bdc71c2d545744b9735c7626385a/packages/block-library/src/embed/edit.native.js#L218-L219

Besides, it's not properly rendered, on iOS the preview is empty and on Android, the content is cut off.

To Reproduce

  1. Add an Embed block.
  2. Use a Pinterest URL (example: https://www.pinterest.com/annsawesomepins/).
  3. Observe that on iOS the inline preview is not displayed and on Android, the preview is cut off.

Expected behavior
The inline preview should be displayed properly or disabled until it's supported.

Screenshots

iOS Android

Smartphone (please complete the following information):

  • Device: iPhone 12 Pro Max, Samsung Galaxy S20 FE 5G
  • OS: iOS 14.5, Android 10
  • Version 18.3

Additional context
Looks like the Pinterest provider has been added recently as per this commit from WordPress repo.

@fluiddot
Copy link
Contributor Author

For now the inline preview will be disabled after merging this PR: #3991

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Embed block [Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant