Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Embed block] Disable inline preview for specific WP embed providers #3991

Merged
merged 2 commits into from
Sep 20, 2021
Merged

[Embed block] Disable inline preview for specific WP embed providers #3991

merged 2 commits into from
Sep 20, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Sep 20, 2021 •
edited
Loading

gutenberg PR: WordPress/gutenberg#34951

Related to #3983

To test:
Follow testing instructions from gutenberg PR: WordPress/gutenberg#34951.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added [Type] Bug Something isn't working Embed block labels Sep 20, 2021
@fluiddot fluiddot self-assigned this Sep 20, 2021
This was referenced Sep 20, 2021
Merged
Open
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 20, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

jd-alexander
jd-alexander approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@jd-alexander jd-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#34951 (review)

@fluiddot fluiddot added this to the 1.63.0 (18.4) milestone Sep 20, 2021
@fluiddot fluiddot enabled auto-merge September 20, 2021 14:36
@fluiddot fluiddot merged commit cb12626 into develop Sep 20, 2021
@fluiddot fluiddot deleted the embed-block-disable-pinterest branch September 20, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jd-alexander jd-alexander jd-alexander approved these changes

@ceyhun ceyhun Awaiting requested review from ceyhun

Assignees

@fluiddot fluiddot

Labels
Embed block [Type] Bug Something isn't working
Projects
None yet
Milestone
1.63.0 (18.4)
Development

Successfully merging this pull request may close these issues.
2 participants
@fluiddot @jd-alexander