Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Title and Paragraph block default placeholder text colors for standard themes #6069

Closed
derekblank opened this issue Aug 16, 2023 · 1 comment · Fixed by WordPress/gutenberg#54259
Assignees

Comments

@derekblank
Copy link
Contributor

When using a standard theme, we are setting a lighter color for the placeholder text color for the Title and the Paragraph blocks. We should update it to the expected color of the recent design changes:

@derekblank
Copy link
Contributor Author

derekblank commented Aug 16, 2023

Hey @geriux 👋 I started working on this one, and just wanted to clarify the intention here. Currently for standard themes, the Post Title and RichText placeholder colors are the same as their globalStyles text color, which makes it seem like there's no distinction between placeholder and "typing" color:

For everything else, we fallback to the default RichText placeholder color.

I understand that we'd want the placeholder text color to be lighter than the "typing" text color. But, for standard themes, I'm wondering if we need to retain the the globalStyles text color and just add some opacity (like what was done on the List Item placeholder color), or if we should remove these globalStyles.text placeholder params in those first two code references, so that standard themes fallback to the default RichText placeholder color too. I am leaning toward removing the globalStyles.color params and just having everything have the same placeholder text color, like in this draft PR. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant