Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try/device tests #1336

Merged
merged 15 commits into from
Sep 2, 2019
Merged

Try/device tests #1336

merged 15 commits into from
Sep 2, 2019

Conversation

JavonDavis
Copy link
Contributor

@JavonDavis JavonDavis commented Aug 29, 2019 •
edited
Loading

Reduces the number of tests ran until issues with tests and sauce labs can be resolved. These subset of tests seem to not result int the server issues.

To test: Check that everything passes in CI, maybe rerun the workflow to make sure everything is ok.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@JavonDavis JavonDavis requested a review from etoledom August 30, 2019 17:41
@JavonDavis JavonDavis self-assigned this Aug 30, 2019
@JavonDavis JavonDavis added the Testing Anything related to automated tests label Aug 30, 2019
@JavonDavis JavonDavis marked this pull request as ready for review August 30, 2019 17:41
@etoledom
Copy link
Contributor

etoledom commented Sep 2, 2019 •
edited
Loading

  • All tests were ✅
  • Just had re-run the workflows and both iOS and Android UI tests failed.
  • Re-running them - they all succeed.
  • One more time and they succeeded again 👍

@JavonDavis
Copy link
Contributor Author

@etoledom everything ok for this to merge?

etoledom
etoledom approved these changes Sep 2, 2019
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three ✅ out of four is a lot better than what we seem to have not. Let's merge! 🎉

@etoledom
Copy link
Contributor

etoledom commented Sep 2, 2019

Thank you @JavonDavis for your big effort! 🙏

@JavonDavis JavonDavis merged commit 46985c0 into develop Sep 2, 2019
@hypest
Copy link
Contributor

hypest commented Sep 3, 2019

👋 @JavonDavis, can you open a ticket to track the re-instate of the skipped tests? Thanks!

@JavonDavis JavonDavis mentioned this pull request Sep 4, 2019
Closed
1 task
@SergioEstevao SergioEstevao deleted the try/device-tests branch January 14, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etoledom etoledom etoledom approved these changes

Assignees

@JavonDavis JavonDavis

Labels
Testing Anything related to automated tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JavonDavis @etoledom @hypest