Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Cross platform InspectorControls #1341

Merged
merged 42 commits into from
Sep 30, 2019
Merged

Feat: Cross platform InspectorControls #1341

merged 42 commits into from
Sep 30, 2019

Conversation

jbinda
Copy link
Contributor

@jbinda jbinda commented Aug 30, 2019 •
edited
Loading

Fixes #1300

Please also refer to:
Related gutenberg-mobile PR
Related gutenberg PR
Related gutenberg-mobile issue

It presents:

  1. PanelBody mobile implementation (currently simple View component)
  2. Refactor of InspectorControls that allows to use it in pretty same manner as on web
  3. Refactor in edit.native.js in image and video block

I would like to open discussion about approach that I've took. Please refer to Related gutenberg PR

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@jbinda jbinda mentioned this pull request Aug 30, 2019
Merged
5 tasks
@pinarol pinarol requested review from pinarol, koke and marecar3 September 2, 2019 12:21
@jbinda jbinda marked this pull request as ready for review September 12, 2019 08:02
@jbinda jbinda mentioned this pull request Sep 25, 2019
Merged
1 task
pinarol
pinarol approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@pinarol pinarol left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Let's not forget to update gutenberg ref and subrepo config after merging the child PR.

@pinarol pinarol mentioned this pull request Sep 25, 2019
Closed
@jbinda
Copy link
Contributor Author

jbinda commented Sep 30, 2019

@pinarol I have update ref to already merged PR in gutenberg and revert .gitmodules changes
Can I merge it after pass tests ?

@jbinda
Copy link
Contributor Author

jbinda commented Sep 30, 2019 •
edited
Loading

tests passed ! 🎉

@pinarol
Copy link
Contributor

pinarol commented Sep 30, 2019

Yes please go ahead 🎉

@jbinda jbinda merged commit 2b1673b into develop Sep 30, 2019
@jbinda jbinda self-assigned this Sep 30, 2019
@jbinda
Copy link
Contributor Author

jbinda commented Sep 30, 2019

done !

@SergioEstevao SergioEstevao deleted the callstack/inspector-controls branch January 14, 2020 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinarol pinarol pinarol approved these changes

@koke koke koke approved these changes

@marecar3 marecar3 Awaiting requested review from marecar3

Assignees

@jbinda jbinda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cross platform InspectorControls component
3 participants
@jbinda @pinarol @koke