Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move MediaUploadPorgress to its own component folder #1361

Merged
merged 7 commits into from
Sep 27, 2019
Merged

Move MediaUploadPorgress to its own component folder #1361

merged 7 commits into from
Sep 27, 2019

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Sep 9, 2019

Gutenberg PR WordPress/gutenberg#17392

Description

This small PR moves MediaUploadProgress out of image (native) to its own component folder. In favor of #1313 to be able to reuse this for the Media & Text block.

To test it:

  • Add an image block and check it works as expected: upload bar, placeholder.
  • Add a video block and check it works as expected: upload bar, placeholder.

@geriux geriux mentioned this pull request Sep 9, 2019
Merged
5 tasks
@geriux geriux requested a review from koke September 23, 2019 19:36
@geriux
Copy link
Contributor Author

geriux commented Sep 27, 2019

@koke ready to be reviewed =)

@koke koke mentioned this pull request Sep 27, 2019
Closed
@koke koke merged commit c364ab4 into develop Sep 27, 2019
@pinarol pinarol added this to the 1.14 milestone Oct 2, 2019
@pinarol pinarol added the Media label Oct 2, 2019
@geriux geriux deleted the feature/move-media-upload-progress branch October 2, 2019 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koke koke koke approved these changes

Assignees

@geriux geriux

Labels
Media
Projects
None yet
Milestone
1.14
Development

Successfully merging this pull request may close these issues.
3 participants
@geriux @koke @pinarol