Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inner Blocks - Breadcrumbs #1369

Merged
merged 22 commits into from
Oct 25, 2019
Merged

Inner Blocks - Breadcrumbs #1369

merged 22 commits into from
Oct 25, 2019

Conversation

dratwas
Copy link
Contributor

@dratwas dratwas commented Sep 19, 2019 •
edited
Loading

Fixes #1316
Gutenberg PR - WordPress/gutenberg#17471
To test:
Select Inner Block and check if breadcrumbs are shown.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@dratwas dratwas marked this pull request as ready for review September 23, 2019 10:58
@pinarol pinarol requested a review from koke September 25, 2019 17:26
@pinarol pinarol added InnerBlocks [Type] Enhancement Improves a current area of the editor labels Sep 25, 2019
@pinarol pinarol added the [Status] Needs Design Review Needs design review or sign-off before shipping label Sep 25, 2019
lukewalczak and others added 14 commits September 26, 2019 09:19
pinarol
pinarol approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dratwas dratwas merged commit 37b45e5 into develop Oct 25, 2019
@SergioEstevao SergioEstevao deleted the feat/breadcrumbs branch April 17, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinarol pinarol pinarol approved these changes

@koke koke koke approved these changes

@iamthomasbishop iamthomasbishop Awaiting requested review from iamthomasbishop

Assignees

@dratwas dratwas

Labels
InnerBlocks [Status] Needs Design Review Needs design review or sign-off before shipping [Type] Enhancement Improves a current area of the editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inner Blocks - Breadcrumbs
4 participants
@dratwas @koke @pinarol @lukewalczak