Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix native test of image block #1456

Merged
merged 2 commits into from
Oct 17, 2019
Merged

Fix native test of image block #1456

merged 2 commits into from
Oct 17, 2019

Conversation

lukewalczak
Copy link
Contributor

Fixes #
Ref to gunteberg: WordPress/gutenberg#17989

To test:

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@lukewalczak lukewalczak mentioned this pull request Oct 17, 2019
Merged
5 tasks
@etoledom etoledom added this to the 1.16 milestone Oct 17, 2019
@etoledom etoledom added the Testing Anything related to automated tests label Oct 17, 2019
etoledom
etoledom approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#17989 (review)
Thank you! 🙏

@lukewalczak lukewalczak merged commit cffce62 into develop Oct 17, 2019
daniloercoli added a commit that referenced this pull request Oct 21, 2019
@daniloercoli
Merge branch 'develop' of https://github.com/wordpress-mobile/gutenbe…
e42e5c0 
…rg-mobile into issue/wp-android-8828-Aztec-crash-Android-8

* 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile: (24 commits)
  Feat: cover cross platform RangeControl (#1342)
  Introduce grouping in the block settings inspector (#1397)
  Fix native test of image block (#1456)
  Update RELEASE notes with iOS11 and Swift 5 update
  Expose WordPressUtils for consumption by gutenberg-bridge
  Update Aztec-Android ref to v1.3.33
  Update bundles
  revert missing toggle editor mode call (#1444)
  Update Aztec-iOS ref to 1.11.0
  Update Aztec-Android ref to v1.3.32
  Update Aztec-iOS ref
  Update bundles
  Bump version to 1.15.0
  Update Gutenberg
  Add Media & Text block to initial HTML
  Update Gutenberg
  Updated bundles
  Update Gutenberg
  Update Gutenberg
  Update gutenberg
  ...

# Conflicts:
#	react-native-aztec/android/build.gradle
daniloercoli added a commit that referenced this pull request Oct 23, 2019
@daniloercoli
Merge branch 'develop' of https://github.com/wordpress-mobile/gutenbe…
fa198f3 
…rg-mobile into issue/wp-android-9832-IndexOutOfBoundsException-setSpan

* 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile:
  Bump version to 1.15.1
  Update bundles
  Update Aztec to the new tagged version v1.3.34
  Feat: cover cross platform RangeControl (#1342)
  Introduce grouping in the block settings inspector (#1397)
  Fix native test of image block (#1456)

# Conflicts:
#	react-native-aztec/android/build.gradle
pinarol pushed a commit that referenced this pull request Oct 28, 2019
@dratwas @pinarol
[FIX] Scroll position android (#1478)
1811d84 
* Fix native test of image block (#1456)

* Add ref to gutenberg repo

* Update ret to point to master

* Introduce grouping in the block settings inspector (#1397)

* Feat: cover cross platform RangeControl (#1342)

* feat: add RangeCell component

* update ref

* update ref and bundle
@SergioEstevao SergioEstevao deleted the callstack/fix/image-native-test branch April 17, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etoledom etoledom etoledom approved these changes

Assignees

@lukewalczak lukewalczak

Labels
Testing Anything related to automated tests
Projects
None yet
Milestone
1.16
Development

Successfully merging this pull request may close these issues.
2 participants
@lukewalczak @etoledom