Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Rich Text loop when autocompleting text on iOS #1702

Merged
merged 13 commits into from
Jan 7, 2020
Merged

[FIX] Rich Text loop when autocompleting text on iOS #1702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
2cce991
fix iOS focus loop
dratwas Dec 19, 2019
9f27fa8
update ref
dratwas Dec 19, 2019
9f8f324
some styling fix
dratwas Dec 19, 2019
ab1e618
update ref
dratwas Dec 19, 2019
b3fc83e
back the TextInputState
dratwas Dec 20, 2019
87c850c
update ref
dratwas Dec 20, 2019
581d7e0
revert changes
dratwas Dec 20, 2019
c62e3b2
remove unused variable
dratwas Dec 20, 2019
7fe9984
update ref
dratwas Dec 20, 2019
0123be7
update ref
dratwas Dec 20, 2019
3d3fb92
remove register and unregister of text input
dratwas Dec 20, 2019
f8a59bd
Merge branch 'release/1.20.0' into fix/rich-text-loop
dratwas Jan 7, 2020
d16c52b
update ref
dratwas Jan 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gutenberg
Open in desktop
Submodule gutenberg updated 1 files
+15 −2 packages/rich-text/src/component/index.native.js
3 changes: 2 additions & 1 deletion react-native-aztec/ios/RNTAztecView/RCTAztecView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,6 +669,7 @@ extension RCTAztecView: UITextViewDelegate {
}

func textViewDidEndEditing(_ textView: UITextView) {
onBlur?([:])
let text = packForRN(cleanHTML(), withName: "text")
onBlur?(text)
}
}
2 changes: 1 addition & 1 deletion react-native-aztec/src/AztecView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ class AztecView extends React.Component {

_onPress = (event) => {
if ( ! this.isFocused() ) {
this.focus(event); // Call to move the focus in RN way (TextInputState)
this.focus(); // Call to move the focus in RN way (TextInputState)
this._onFocus(event); // Check if there are listeners set on the focus event
}
}
Expand Down