Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct isMobile condition in nested Media&Text #1791

Closed
wants to merge 5 commits into from
Closed

Correct isMobile condition in nested Media&Text #1791

wants to merge 5 commits into from

Conversation

lukewalczak
Copy link
Contributor

@lukewalczak lukewalczak commented Jan 21, 2020 •
edited
Loading

Fixes: nested Media&Text component is not presented in a stacked layout.

More details inside gutenberg PR

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@lukewalczak lukewalczak self-assigned this Jan 21, 2020
@lukewalczak lukewalczak mentioned this pull request Jan 21, 2020
Closed
2 tasks
@pinarol pinarol requested a review from koke January 21, 2020 14:47
@lukewalczak
Copy link
Contributor Author

Closing since gutenberg equivalent is already merged and ref to gutenberg was merged with other gb-mobile PR.

@lukewalczak lukewalczak deleted the fix-vertical-nested-media-text branch January 29, 2020 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koke koke Awaiting requested review from koke

Assignees

@lukewalczak lukewalczak

Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lukewalczak