Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix list changing style crash #1803

Closed
wants to merge 2 commits into from
Closed

Fix list changing style crash #1803

wants to merge 2 commits into from

Conversation

SergioEstevao
Copy link
Contributor

This PR updates the GB reference to fix an issue when switching list styles on the list block.

This is related to #1778

To test:

  • Start the demo app
  • Select a list block
  • Switch the style to ordered list and see that no crash happens.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@SergioEstevao SergioEstevao added the [Type] Bug Something isn't working label Jan 22, 2020
@SergioEstevao SergioEstevao added this to the 1.22 milestone Jan 22, 2020
@SergioEstevao SergioEstevao requested a review from geriux January 22, 2020 23:06
@SergioEstevao SergioEstevao mentioned this pull request Jan 22, 2020
Closed
6 tasks
@hypest
Copy link
Contributor

hypest commented Jan 23, 2020

FYI, #1801 has introduced the same fix but on the ongoing release branches.

@SergioEstevao SergioEstevao deleted the issue/fix_focus_issue branch April 17, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriux geriux Awaiting requested review from geriux

Assignees
No one assigned
Labels
[Type] Bug Something isn't working
Projects
None yet
Milestone
1.22
Development

Successfully merging this pull request may close these issues.
2 participants
@SergioEstevao @hypest