Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable gallery size options in v1.21.0 #1804

Merged
merged 2 commits into from
Jan 23, 2020

Conversation

mkevins
Copy link
Contributor

@mkevins mkevins commented Jan 23, 2020

Issue: #1792

Related PRs:

gutenberg: WordPress/gutenberg#19828

Description

This PR disables the gallery image size options on mobile. We can re-enable them after we've verified / implemented the desired behavior for mobile.

To test:

Steps:

  • Create a gallery block with some images
  • Tap the gallery
  • Tap the gallery settings icon (the gear)

Expected result:

The image size option should not be visible in the menu.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#19828 (review)

Thank you @mkevins !

@etoledom etoledom added this to the 1.21 milestone Jan 23, 2020
@mkevins mkevins merged commit 1cb2961 into release/1.21.0 Jan 23, 2020
@mkevins
Copy link
Contributor Author

mkevins commented Jan 23, 2020

Thanks @etoledom for reviewing and testing!

@etoledom etoledom deleted the fix/disable-gallery-size-options branch January 23, 2020 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants