Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename iOS module name of sample app from gutenberg to GutenbergDemo. #1820

Merged
merged 4 commits into from
Jan 27, 2020

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Jan 24, 2020

With the update to React 0.61.5 the iOS demo project is now built using CocoaPods.

This creates a scenario where sometimes Xcode build system gets confused between the pod library Gutenberg (the Gutenberg Bridge podspec) and the binary of the demo project itself: gutenberg.

You will see Xcode sometimes complaining that we are importing Gutenberg instead of gutenberg, and after getting on this state you will probably need to clean all build folders and restart the project.

So the solution I propose here is to rename the module name of the gutenberg.xcodeproj from gutenberg to GutenbergDemo to avoid these conflicts going forward.

To test:

  • Check if projects build
  • Check that tests build and pass

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

This is to avoid conflicts with the pod Gutenberg.
Copy link
Member

@koke koke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, and seems to work fine after cleaning the build folder 👌

@SergioEstevao SergioEstevao merged commit c71ecba into develop Jan 27, 2020
@SergioEstevao SergioEstevao deleted the try/rename_demo_version_2 branch January 27, 2020 11:00
@hypest
Copy link
Contributor

hypest commented Jan 31, 2020

👋 @SergioEstevao , as a follow up, do you think that we could/should also rename the local files that are still named as "gutenberg.xxx"? For example, all the files/folders in https://github.com/wordpress-mobile/gutenberg-mobile/tree/develop/ios are still named/prefixed gutenberg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants