Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes the Image's media button not displaying the Picker #1827

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Fixes the Image's media button not displaying the Picker #1827

merged 1 commit into from
Jan 28, 2020

Conversation

leandroalonso
Copy link
Contributor

@leandroalonso leandroalonso commented Jan 28, 2020 •
edited
Loading

Fixes the Action Sheet / Picker not being displayed.

Gutenberg PR: WordPress/gutenberg#19934

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

mchowning
mchowning approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :shipit:

@leandroalonso leandroalonso merged commit 1616ba1 into develop Jan 28, 2020
@leandroalonso leandroalonso deleted the issue/1583_fix_action_sheet_for_media_editing_button branch January 28, 2020 21:10
@hypest
Copy link
Contributor

hypest commented Jan 29, 2020

👋 @leandroalonso ! When you get the chance, please add a link in the description to the Gutenberg side PR to be easy to get there, thanks!

This was referenced Feb 3, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchowning mchowning mchowning approved these changes

Assignees
No one assigned
Labels
bugfix Media
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leandroalonso @hypest @mchowning