Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project cleanup #1833

Merged
merged 5 commits into from
Jan 29, 2020
Merged

Project cleanup #1833

merged 5 commits into from
Jan 29, 2020

Conversation

SergioEstevao
Copy link
Contributor

This PR cleans up some iOS project definitions to make the project cleaner on iOS. It also updates the initial content HTML to avoid transformation warnings on startup.

To test:

  • Make sure the app builds and runs.
  • Check the demo content.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

etoledom
etoledom approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Tested with yarn iOS and running from Xcode 👍

@SergioEstevao
Add an option to run the iOS project without updating the pod spec an…
83e6f22 
…d doing pod install.

For the cases you just changing local code and no pods are changed.
@SergioEstevao SergioEstevao merged commit 1a604be into develop Jan 29, 2020
@SergioEstevao SergioEstevao deleted the issue/project_cleanup branch January 29, 2020 14:00
This was referenced Feb 3, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etoledom etoledom etoledom approved these changes

@koke koke Awaiting requested review from koke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SergioEstevao @etoledom