-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Floating Toolbar Ideal Version #2029
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Closing this PR as we explore other options: #1414 (comment) |
Renamed the original branch to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1414
Related PRs:
gutenberg:
WordPress/gutenberg#20971Description
This PR is currently still a spoke being opened to help share progress. This adds additional library components that are still being discussed on where they should ideally live
To Run:
Pre-condition: Make sure you also have the correct
gutenberg
branch pulled downAndroid:
Make sure you run
yarn android
to install the new gradle dependencies.You can also open Android Studio and build for your device if desired.
iOS:
Make sure you run
yarn ios
to install the local development Pod.You can then open Xcode and build for your device if desired.
Known Issues:
PR submission checklist:
RELEASE-NOTES.txt
if necessary.