Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating Toolbar Ideal Version #2029

Closed
wants to merge 17 commits into from
Closed

Floating Toolbar Ideal Version #2029

wants to merge 17 commits into from

Conversation

chipsnyder
Copy link
Contributor

@chipsnyder chipsnyder commented Mar 17, 2020

Fixes: #1414
Related PRs:
gutenberg: WordPress/gutenberg#20971

Description

This PR is currently still a spoke being opened to help share progress. This adds additional library components that are still being discussed on where they should ideally live

To Run:

Pre-condition: Make sure you also have the correct gutenberg branch pulled down

Android:

Make sure you run yarn android to install the new gradle dependencies.
You can also open Android Studio and build for your device if desired.

iOS:

Make sure you run yarn ios to install the local development Pod.
You can then open Xcode and build for your device if desired.

Known Issues:

  1. iOS: Tapping on an InnerBlock inside a Group will select the InnerBlock before the Group.
  2. Android: Long pressing on the toolbar allows the cursor to move to the overlapped Block without selecting it.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@chipsnyder
Copy link
Contributor Author

Closing this PR as we explore other options: #1414 (comment)

@chipsnyder chipsnyder closed this Mar 25, 2020
@chipsnyder chipsnyder deleted the spike/float branch March 25, 2020 19:37
@chipsnyder
Copy link
Contributor Author

Renamed the original branch to spike/floatingToolbar_OverflowView to make it more clear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant