-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Master -> Develop 1.28.1 #2313
Conversation
…exceptions Fix Android Invalid Span Crashes
Hotfix Release 1.28.1
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
👋 @SergioEstevao . Please take a look at c30e2fa and make sure I resolved the Podfile conflict the right way. |
Marking this as a draft until we have a WPAndroid PR ready to go with the matching changes for 1.28.1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I smoke tested on iOS and Android and is looking good.
I can locally recreate the failure that is showing with the Android device tests on CI. It is with a new test I added for 1.28.1. I'm not sure why it is failing now that The issue is that when the device test sends a "\n" to a list block, it creates a new list item but does not move the cursor to the new list item. If I manually execute the test, everything works as it should (pressing "Enter" creates a new list item and moves the cursor to the new list item). I haven't had time to investigate this much, but I will pick it up first thing in the morning. I know we need to get this merged in order to create the 1.29.0 release branches. One way we could not make this test block us would be to disable the failing test, and create an issue to fix that test. Either way, I'll look into it first thing tomorrow. |
Merge master to develop with 1.28.1 release
Had to create a new branch to resolve conflicts. There were conflicts in the bundle files, so I just generated new bundles.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.