Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing context prop in BlockEdit component #3208

Merged
merged 3 commits into from
Mar 3, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Mar 2, 2021

gutenberg PR: WordPress/gutenberg#29479

Fixes WordPress/gutenberg#29471

To test:
Instructions are described in the the "How has this been tested?" section of the Gutenberg PR.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

Sorry, something went wrong.

@fluiddot fluiddot added [Type] Bug Something isn't working Web breakage Caused by incompatible changes on Gutenberg web labels Mar 2, 2021
@fluiddot fluiddot added this to the 1.49.0 (17.0) milestone Mar 2, 2021
@cameronvoell cameronvoell self-requested a review March 2, 2021 17:29
Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#29479.

Looks like iOS file test failed on first attempt, but I think it was just a flake, as I tested the file block on iOS and the file test passed when I enabled full suite of tests.

Let's see if test passes on second attempt after restart. If that passes we'll be ready to merge after updating the gutenberg ref 👍

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 2, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@fluiddot
Copy link
Contributor Author

fluiddot commented Mar 2, 2021

Approved via WordPress/gutenberg#29479.

Looks like iOS file test failed on first attempt, but I think it was just a flake, as I tested the file block on iOS and the file test passed when I enabled full suite of tests.

Let's see if test passes on second attempt after restart. If that passes we'll be ready to merge after updating the gutenberg ref 👍

All the tests passed so I'm going to update the Gutenberg reference with the merge commit from trunk and merge the PR.

@fluiddot fluiddot merged commit 1f01a83 into develop Mar 3, 2021
@fluiddot fluiddot deleted the fix/block-edit-context branch March 3, 2021 08:52
@enejb
Copy link
Contributor

enejb commented Mar 3, 2021

Should this change make it into 1.48.0 ? release

@fluiddot
Copy link
Contributor Author

fluiddot commented Mar 3, 2021

Should this change make it into 1.48.0 ? release

This fix is only required to be included if we include the changes from the Gutenberg PR that introduced the bug.

I see that the release was branched off from a commit before that one so it's not needed, thanks for the heads-up 🙇 .

Screenshot 2021-03-03 at 18 48 07

@jd-alexander
Copy link
Contributor

Looks like iOS file test failed on first attempt, but I think it was just a flake, as I tested the file block on iOS and the file test passed when I enabled full suite of tests.

Hi @cameronvoell Just to chime in here, did you by any chance have a look at the error log for this failure? Because I utilized sleep calls to ensure that the media picker bottom sheet is shown before making a selection and it was flaky in the past but I thought it was resolved now. I also know that other issues have been taking place in the UI tests, so I want to assist in any way possible to reduce the flakiness, as I know it impacts developer productivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working Web breakage Caused by incompatible changes on Gutenberg web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Spacer block generates an error
4 participants