Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crashes editing More block #329

Merged
merged 2 commits into from
Dec 5, 2018
Merged

Fix crashes editing More block #329

merged 2 commits into from
Dec 5, 2018

Conversation

daniloercoli
Copy link
Contributor

This PR fixes an issue on the More block, that makes the app unstable/crashing when editing the content of the block. Fix #316

GB side PR here: WordPress/gutenberg#12620

Testing Steps

  • Open the demo app (android or iOS)
  • Tap into the "Read more" block.
  • Edit the content of the block

It should not crash.

Test the same on the Code block, that internally uses PlainText.

@daniloercoli daniloercoli requested a review from mzorz December 5, 2018 17:56
@daniloercoli
Copy link
Contributor Author

GB side reviewed and merged!

mzorz
mzorz approved these changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@mzorz mzorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, this fixes it! Thank you @daniloercoli
LGTM :shipit:

@daniloercoli daniloercoli merged commit 27f0ff8 into master Dec 5, 2018
@daniloercoli daniloercoli deleted the issue/316-editing-more-block-crash branch December 5, 2018 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzorz mzorz mzorz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniloercoli @mzorz