-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scroll to new-block indicator #3414
Conversation
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
Note to self: Looks like one iOS UI test (
and this REPL commands:
the last of which outputted: "Post title. Welcome to Gutenberg! File Block. Row 1 Paragraph Block. Row 2. Empty Add paragraph block". Edit: same block is found on current gb-mobile develop, so the issue must be different. I suspect the change to the list footer that enlarged the tapping area for appending a new block. Another note to self: Some commands to try and cleanup the ios build to fix the
System Ruby was 2.6.0 while the gb-mobile nested one was 2.6.0 so, went ahead and For some reason, the enlarged block appender in the list footer is triggered on iOS when clicking the first component detected using the |
fa323c2
to
55b9407
Compare
Closing since the functionality is already in at this point. |
Fixes #1672
Adds automatic scrolling to where the block inserter is on native mobile, when adding a new block (Block Picker active). Not covering the case of adding a new block inside a group/innerblock block.
Gutenberg PR: WordPress/gutenberg#31144
To test:
TBD
PR submission checklist: