Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undo/redo on new Para/Heading blocks #361

Merged
merged 2 commits into from
Dec 12, 2018
Merged

Fix undo/redo on new Para/Heading blocks #361

merged 2 commits into from
Dec 12, 2018

Conversation

daniloercoli
Copy link
Contributor

This PR fixes a problem with undo/redo not working on new (empty) blocks after writing some text.
Fixes #360

GB side PR: WordPress/gutenberg#12815

Steps to test:

  • Create a new post
  • Start a paragraph
  • Type hello
  • Tap undo: it should go back to an empty paragraph
  • Tap undo: paragraph removed
  • Tap redo: empty paragraph restored
  • Tap redo: "hello" restored

Note: The cursor is not restored to the correct position at the last step. we have another PR open for this: #309

@daniloercoli daniloercoli added the [Type] Bug Something isn't working label Dec 12, 2018
@daniloercoli daniloercoli added this to the Alpha milestone Dec 12, 2018
@daniloercoli daniloercoli requested review from koke and mzorz December 12, 2018 15:27
@daniloercoli daniloercoli mentioned this pull request Dec 12, 2018
Merged
mzorz
mzorz approved these changes Dec 12, 2018
View reviewed changes
Copy link
Contributor

@mzorz mzorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, worked 👌

@daniloercoli daniloercoli merged commit 83cd3eb into master Dec 12, 2018
@daniloercoli daniloercoli deleted the issue/360-fix-undo-redo-new-block branch December 12, 2018 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzorz mzorz mzorz approved these changes

@koke koke koke approved these changes

Assignees
No one assigned
Labels
[Type] Bug Something isn't working
Projects
None yet
Milestone
Alpha
Development

Successfully merging this pull request may close these issues.
3 participants
@daniloercoli @koke @mzorz