Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GB hash and fix Keyboard dismissed when enter.key is pressed #383

Merged
merged 2 commits into from
Dec 14, 2018

Conversation

daniloercoli
Copy link
Contributor

@daniloercoli daniloercoli commented Dec 14, 2018

This PR updates the GB hash and fixes #381 by reverting the changes introduced #341

Testing steps:

  • Tap on a para block
  • Tap enter
  • The new block should be created and the keyboard is up

Repeat the step above for Heading and Title block.

GB side companion PR: WordPress/gutenberg#12886

Make sure to re-open #308 when this is merged for the alpha.

Copy link
Contributor

@mzorz mzorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Make sure to re-open #308 when this is merged for the alpha.

remember to do it on merge ! :D

@daniloercoli daniloercoli merged commit 10b428b into master Dec 14, 2018
@daniloercoli daniloercoli deleted the issue/381-Keyboard-gets-dismissed-when-enter.key branch December 14, 2018 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants