[Embed block] - Unavailable preview fallback bottom sheet title update

[jd-alexander]

To test:
Utilize the testing instructions at WordPress/gutenberg#34674

PR submission checklist:

• I have considered adding unit tests where possible.
• I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

[peril-wordpress-mobile]

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

[fluiddot]

Approved via WordPress/gutenberg#34674 (review).

[jd-alexander]

@fluiddot I have the same node and npm version as CI. When I run npm install I and push the diff of the package-lock.json file is still fails. I am not sure what is wrong locally that could be causing this. Do you have any clues ?

[fluiddot]

@fluiddot I have the same node and npm version as CI. When I run npm install I and push the diff of the package-lock.json file is still fails. I am not sure what is wrong locally that could be causing this. Do you have any clues ?

Not really, but I noticed that the last Dependabot's PR "Bump gutenberg from cb459f8 to e48adc4" is also failing due to a mismatch on that file:

index 39eb5f8..b79d955 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -6253,8 +6253,8 @@
 			"version": "file:gutenberg/packages/eslint-plugin",
 			"dev": true,
 			"requires": {
-				"@typescript-eslint/eslint-plugin": "^4.15.0",
-				"@typescript-eslint/parser": "^4.15.0",
+				"@typescript-eslint/eslint-plugin": "^4.31.0",
+				"@typescript-eslint/parser": "^4.31.0",
 				"@wordpress/prettier-config": "file:gutenberg/packages/prettier-config",
 				"babel-eslint": "^10.1.0",
 				"cosmiconfig": "^7.0.0",

So this might be an incoming breakage from the Gutenberg's trunk branch, I'll try it locally in case I found a workaround.

[fluiddot]

@fluiddot I have the same node and npm version as CI. When I run npm install I and push the diff of the package-lock.json file is still fails. I am not sure what is wrong locally that could be causing this. Do you have any clues ?

Not really, but I noticed that the last Dependabot's PR "Bump gutenberg from cb459f8 to e48adc4" is also failing due to a mismatch on that file:

index 39eb5f8..b79d955 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -6253,8 +6253,8 @@
 			"version": "file:gutenberg/packages/eslint-plugin",
 			"dev": true,
 			"requires": {
-				"@typescript-eslint/eslint-plugin": "^4.15.0",
-				"@typescript-eslint/parser": "^4.15.0",
+				"@typescript-eslint/eslint-plugin": "^4.31.0",
+				"@typescript-eslint/parser": "^4.31.0",
 				"@wordpress/prettier-config": "file:gutenberg/packages/prettier-config",
 				"babel-eslint": "^10.1.0",
 				"cosmiconfig": "^7.0.0",

So this might be an incoming breakage from the Gutenberg's trunk branch, I'll try it locally in case I found a workaround.

I've just noticed that you fixed this in commit 4b66b80 so I'm not sure yet what's causing this 🤔 .

[fluiddot]

I managed to fix it by running the command npm install @typescript-eslint/eslint-plugin@latest --save-dev as it's mentioned in the error message:

ESLint couldn't find the plugin "@typescript-eslint/eslint-plugin".

(The package "@typescript-eslint/eslint-plugin" was not found when loaded as a Node module from the directory "/home/circleci/project".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

    npm install @typescript-eslint/eslint-plugin@latest --save-dev

The plugin "@typescript-eslint/eslint-plugin" was referenced from the config file in ".eslintrc.js » plugin:@wordpress/recommended".

However, I'm not sure why we need this is needed now if that package was referenced weeks ago (reference) 🤔 .

[fluiddot]

I managed to fix it by running the command npm install @typescript-eslint/eslint-plugin@latest --save-dev as it's mentioned in the error message

I applied this fix in "Bump gutenberg from cb459f8 to e48adc4" PR and the "Check Correctness" job passed 🟢 .

[fluiddot]

However, I'm not sure why we need this is needed now if that package was referenced weeks ago (reference) 🤔 .

Ok, looks like it's caused by the modification of the package-lock.json file, here you can see that the @typescript-eslint/eslint-plugin root-level dependency is removed. Nevertheless, it's still unclear to me why it gets removed 🤔 .

[jd-alexander]

Ok, looks like it's caused by the modification of the package-lock.json file, here you can see that the @typescript-eslint/eslint-plugin root-level dependency is removed. Nevertheless, it's still unclear to me why it gets removed 🤔 .

Ah, understood! I will sync with develop once #3955 is merged in. 🙏🏾

[fluiddot]

Ok, looks like it's caused by the modification of the package-lock.json file, here you can see that the @typescript-eslint/eslint-plugin root-level dependency is removed. Nevertheless, it's still unclear to me why it gets removed 🤔 .

Ah, understood! I will sync with develop once #3955 is merged in. 🙏🏾

I've just merged #3955 into develop so feel free to sync it.