Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Media File and Attachment Page options to the native Image block Link To menu #3971

Merged
merged 20 commits into from
Nov 3, 2021

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Sep 16, 2021

Related PRs

Description

Add Media File and Attachment Page options to the native Image block Link To menu to allow quickly setting commonly used URLs. This feature already exists in the web interface.

To test: See WordPress/gutenberg#34846

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 16, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@dcalhoun dcalhoun marked this pull request as ready for review September 21, 2021 19:17
@dcalhoun dcalhoun requested a review from mkevins September 21, 2021 19:17
@dcalhoun dcalhoun added this to the 1.66.0 (18.7) milestone Nov 1, 2021
Copy link
Contributor

@mkevins mkevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via: WordPress/gutenberg#34846 (review) . We can revert the bundles, and merge the reference update and release note. Nice work David! 👍

@dcalhoun dcalhoun enabled auto-merge November 3, 2021 12:07
@dcalhoun dcalhoun merged commit a5ed77b into develop Nov 3, 2021
@dcalhoun dcalhoun deleted the feature/link-image-to-media branch November 3, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants