Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try running full tests on release PRs #4151

Merged
merged 3 commits into from
Oct 29, 2021

Conversation

guarani
Copy link
Contributor

@guarani guarani commented Oct 22, 2021

This change proposes creating new jobs on CircleCI that will run full tests on release PRs. Previously these changes were optional.

Addresses wordpress-mobile/release-toolkit-gutenberg-mobile#78 (this issue can only be marked resolved when wordpress-mobile/release-toolkit-gutenberg-mobile#79 is also merged)

To test

  1. Note that this PR's base branch is of the format release/.*, which should make this PR behave like a release PR in that optional tests should be run automatically.
  2. Verify that the full tests suite is ran for both platforms.

This PR currently creates a new job to run the tests. We already have a job, Test Android on Device - Full (Submodule Update), to run tests automatically on Dependabot PRs, but I chose to make a new job to allow customizing the job name to Test Android on Device - Full (Release). If you think it's best to combine these jobs under a more generic name such as Test Android on Device - Full, that's also something we can do.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

This change proposes creating new jobs on CircleCI that will run full tests on release PRs. Previously these changes were optional.
guarani added a commit to wordpress-mobile/release-toolkit-gutenberg-mobile that referenced this pull request Oct 22, 2021
If wordpress-mobile/gutenberg-mobile#4151 is merged, it makes sense to remove this checklist step now that running optional tests is automatic.
@guarani guarani requested a review from geriux October 28, 2021 18:55
@guarani guarani marked this pull request as ready for review October 28, 2021 18:55
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👏 the full tests for both platforms were run.

I think it's good to have a different job with a different name so it's easier to differentiate. Thanks for improving this @guarani!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants