Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS: Use firstChild and lastChild when parsing lists from MS Word #4174

Merged
merged 4 commits into from
Nov 10, 2021

Conversation

twstokes
Copy link
Contributor

@twstokes twstokes commented Oct 28, 2021

Fixes #4145

Related PRs:

To test:

See Gutenberg PR for testing instructions.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@twstokes twstokes self-assigned this Nov 1, 2021
@twstokes twstokes added the [Type] Bug Something isn't working label Nov 1, 2021
@twstokes twstokes force-pushed the fix/ms-list-firstchild branch from 06ea47e to 9a0d3fa Compare November 2, 2021 15:55
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 2, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@twstokes twstokes changed the title Use firstChild when parsing lists from MS Word Use firstChild and lastChild when parsing lists from MS Word Nov 4, 2021
@twstokes twstokes force-pushed the fix/ms-list-firstchild branch from 8a43adc to d683190 Compare November 9, 2021 18:04
@twstokes twstokes requested a review from hypest November 10, 2021 01:51
@twstokes twstokes marked this pull request as ready for review November 10, 2021 01:51
@twstokes
Copy link
Contributor Author

@hypest would you mind providing a review for this? Thank you!

@twstokes twstokes added this to the 1.66.0 (18.7) milestone Nov 10, 2021
@twstokes twstokes requested a review from fluiddot November 10, 2021 17:42
@fluiddot
Copy link
Contributor

Hey @twstokes !
We will cut the 1.66.0 release on 2021-11-11. I plan to circle back and bump this PR to the next milestone then, but please let me know if you’d rather us work to include this PR in 1.66.0. Thanks!

@twstokes
Copy link
Contributor Author

Hey @fluiddot 👋! Thanks for the ping, I just now added this PR to the milestone and wondered if you could give it a look. The Gutenberg counterpart has been merged. Thank you!

@fluiddot
Copy link
Contributor

Hey @fluiddot 👋! Thanks for the ping, I just now added this PR to the milestone and wondered if you could give it a look. The Gutenberg counterpart has been merged. Thank you!

No problem, if the Gutenberg PR is already merged it would be quick to review it 💨 .

Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊 !

@twstokes twstokes merged commit 5400724 into develop Nov 10, 2021
@twstokes twstokes deleted the fix/ms-list-firstchild branch November 10, 2021 17:56
@hypest
Copy link
Contributor

hypest commented Nov 11, 2021

Friendly suggestion @twstokes , it's usually best to avoid merging any parts of the PR "domino" (main apps/gb-mobile/Gutenberg PR chain) until all PRs get green and LGTM'd. It's not a guarantee but, that usually helps avoid surprises when a PR ends up needing some more work but the other is already merged. Thanks!

@twstokes
Copy link
Contributor Author

Friendly suggestion @twstokes , it's usually best to avoid merging any parts of the PR "domino" (main apps/gb-mobile/Gutenberg PR chain) until all PRs get green and LGTM'd. It's not a guarantee but, that usually helps avoid surprises when a PR needs ends up needing some more work but the other is already merged. Thanks!

Thanks @hypest, that's true - I had it in my mind that GB Mobile wasn't "complete" until pointed to the GB trunk hash, but that's definitely trickier if things need more work. Will do!

@fluiddot fluiddot mentioned this pull request Nov 11, 2021
4 tasks
@dcalhoun dcalhoun mentioned this pull request Nov 12, 2021
4 tasks
@twstokes twstokes changed the title Use firstChild and lastChild when parsing lists from MS Word iOS: Use firstChild and lastChild when parsing lists from MS Word Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[OS] iOS [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhandled JS Exception: TypeError: undefined is not an object (evaluating 't._parentNode=null')
3 participants