-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS: Use firstChild and lastChild when parsing lists from MS Word #4174
Conversation
06ea47e
to
9a0d3fa
Compare
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
8a43adc
to
d683190
Compare
@hypest would you mind providing a review for this? Thank you! |
Hey @twstokes ! |
Hey @fluiddot 👋! Thanks for the ping, I just now added this PR to the milestone and wondered if you could give it a look. The Gutenberg counterpart has been merged. Thank you! |
No problem, if the Gutenberg PR is already merged it would be quick to review it 💨 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎊 !
Friendly suggestion @twstokes , it's usually best to avoid merging any parts of the PR "domino" (main apps/gb-mobile/Gutenberg PR chain) until all PRs get green and LGTM'd. It's not a guarantee but, that usually helps avoid surprises when a PR ends up needing some more work but the other is already merged. Thanks! |
Thanks @hypest, that's true - I had it in my mind that GB Mobile wasn't "complete" until pointed to the GB trunk hash, but that's definitely trickier if things need more work. Will do! |
Fixes #4145
Related PRs:
To test:
See Gutenberg PR for testing instructions.
PR submission checklist: