Disable BottomSheet swipe gesture to navigate backwards #4215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
twstokes
approved these changes
Nov 5, 2021
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
This was referenced Nov 11, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
Description
Relates to WordPress/gutenberg#36231. The bottom sheet (react-native-modal) and sub sheet navigation (React Navigation) have competing gesture handlers that do not work well together at this time. E.g it is possible to trigger both simultaneously. Until we add logic to prevent the simultaneous gesture, we are disabling the swipe back gesture for sub sheet navigation. We have discussed replacing the BottomSheet logic entirely, so that may be a better time to address this gesture issue.
To test: See WordPress/gutenberg#36271.
PR submission checklist: