Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.67.0 #4289

Merged
merged 60 commits into from
Nov 26, 2021
Merged

Release 1.67.0 #4289

merged 60 commits into from
Nov 26, 2021

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Nov 25, 2021 •
edited
Loading

Release for Gutenberg Mobile 1.67.0

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Change 1

When users have a link copied to their clipboard and then access the "link to" settings panel from the Image or Buttons block, they'll now see a suggestion to paste their clipboard link.

Change 2

The embed block now includes link settings directly in the block's settings sheet.

Change 3

This PR fixes a bug where the titles of the tabs displayed in the inserter menu were not being localized.

Change 4

A bug existed for simple WordPress.com sites where adding a Gallery block from the Inserter didn't result in the media selection sheet opening automatically. This PR addresses that bug.

Change 5

This PR addresses an issue with the Media and Text block, where the text font size would be bigger than expected in some cases.

Test plan

  • Use the main WP apps to test the changes above.
  • Smoke test the main WP apps for general writing flow.
  • Test the Unsupported Block Editor on WP Apps (see steps).
  • Sanity test suites for WP Apps should be completed for each platform.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

jd-alexander and others added 30 commits November 2, 2021 01:48
@jd-alexander
Update gutenberg ref.
8e6bb78
@jd-alexander
Added RELEASE-NOTES entry.
af0c79a
Update reference to Gutenberg
11c76ea
@jhnstn
Update Gutenberg submodule
f1f6e14
@dependabot
Bump gutenberg from 1dc8d6d to b2b868e
370437b 
Bumps [gutenberg](https://github.com/WordPress/gutenberg) from `1dc8d6d` to `b2b868e`.
- [Release notes](https://github.com/WordPress/gutenberg/releases)
- [Commits](WordPress/gutenberg@1dc8d6d...b2b868e)

---
updated-dependencies:
- dependency-name: gutenberg
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@jhnstn
Trigger Build
26ba72e
Update reference to Gutenberg
cf6b2d7
Update reference to Gutenberg
0578ecb
Merge branch 'develop' into try/hide-child-block-controls
13a524d
@fluiddot
Update Gutenberg ref
06466a3
@fluiddot
Update package-lock.json file
34ae465 
This modification is required due to the update of Babel packages to 7.16 version in Gutenberg (PR reference: WordPress/gutenberg#36244).
@fluiddot
Update Gutenberg ref
9294a1e
@fluiddot
Update Gutenberg ref with merge commit
fc32820
@fluiddot
Merge branch 'develop' into issue-3887/embed-block-link-to
57cb5d2
@fluiddot
Merge pull request #4234 from wordpress-mobile/dependabot/submodules/…
2e04dc2 
…gutenberg-b2b868e

Bump gutenberg from `1dc8d6d` to `b2b868e`
@fluiddot
Merge branch 'develop' into issue-3887/embed-block-link-to
96d2b88
@fluiddot
Merge branch 'develop' into merge_release_1.66.0_to_develop
9b2bdcf
@fluiddot
Merge pull request #4189 from wordpress-mobile/issue-3887/embed-block…
f97d742 
…-link-to

[Embed block] - Link in Block Settings
@fluiddot
Merge branch 'develop' into merge_release_1.66.0_to_develop
7369ca7
@fluiddot
Update release notes
d430ffd
@fluiddot
Merge pull request #4231 from wordpress-mobile/merge_release_1.66.0_t…
bc01f46 
…o_develop

Merge release 1.66.0 to develop
@dcalhoun
Update Gutenberg ref
2ae3ad6
@dcalhoun
Merge branch 'develop' of github.com:wordpress-mobile/gutenberg-mobil…
bd576ff 
…e into merge_release_1.65.1_to_develop
@dcalhoun
Merge pull request #4241 from wordpress-mobile/merge_release_1.65.1_t…
acc65ec 
…o_develop

Merge release 1.65.1 to develop
Update reference to Gutenberg
b2dacb5
Merge branch 'develop' into try/hide-child-block-controls
21138b8
Update reference to Gutenberg
9a29ec8
Merge pull request #4225 from wordpress-mobile/try/hide-child-block-c…
8323c11 
…ontrols

Enable child block settings to be hidden via parent block
@fluiddot
Update Gutenberg ref
e64832f
@fluiddot
Update release notes
2a70967
This was referenced Nov 25, 2021
Merged
Merged
Merged
Siobhan added 4 commits November 25, 2021 09:31
Update reference to Gutenberg
ef23ab8
Update RELEASE-NOTES for 1.67.0 release
7fdec87
Revert changes in string localization files
decb66d 
For further details on bug that requires this manual change, see: #3466
Correct positioning of strings in localizations file
ac3a872 
Correcting a couple of strings I'd placed in the wrong position following the last commit.
@SiobhyB SiobhyB marked this pull request as ready for review November 25, 2021 11:11
@jd-alexander jd-alexander merged commit 29e56f7 into trunk Nov 26, 2021
@jd-alexander jd-alexander deleted the release/1.67.0 branch November 26, 2021 03:38
@SiobhyB
Copy link
Contributor Author

SiobhyB commented Nov 30, 2021 •
edited
Loading

🟢 Writing Flow Test Cases (iOS)

Tested with build 18.8 on an iPhone XR (iOS 14.6).

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@SiobhyB
Copy link
Contributor Author

SiobhyB commented Nov 30, 2021 •
edited
Loading

🟢 Unsupported Block Tests (iOS)

Tested with build 18.8 on an iPhone XR (iOS 14.6).

  • TC001 User can edit unsupported blocks on Simple WP.com sites
  • TC002 User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@SiobhyB
Copy link
Contributor Author

SiobhyB commented Nov 30, 2021 •
edited
Loading

🟢 Test Suite 3 (iOS)

Tested with build 18.8 on an iPhone XR (iOS 14.6).

Gallery - 2

  • Gallery block - Insert image from device (failing) - TC006
  • Gallery block - Insert image from device (cancel) - TC009

Gallery - 3

  • Gallery block - Add Gallery Caption - TC003
  • Gallery block - Add Gallery Image Caption - TC004
  • Gallery block - Try adding same images from WP Media library and moving the images around - TC010

Gallery - 4

  • Gallery block - Settings: Link to - TC012
  • Gallery block - Settings: Column number - TC013
  • Gallery block - Settings: Crop images - TC014

Columns - 2

  • Columns - Max limit of Column number - steps
  • Columns - Min limit of Column number - steps
  • Columns - Removing Column with remove button - steps
  • Columns - Removing the only one left Column with remove button - steps
  • Columns - Changing alignment on Columns - steps
  • Columns - Changing alignment on individual Columnn - steps
  • Columns - Alignment attribute is properly passed when adding Column - steps
  • Columns - Deep nesting is possible (iOS only)- steps

Columns - 3

  • Columns - Check if Column placeholders is visible for the unselected state - steps
  • Columns - Appearance in vertical device position (vertical layout) - steps
  • Columns - Appearance in horizontal device position (horizontal layout) - steps
  • Columns - Mover direction - steps
  • Columns - Check if Column placeholder is render in nested structure - steps
  • Columns - Unselected Column placeholder is streched to content in nested structure- steps

Columns - 4

  • Columns - Check if in DarkMode all components gets proper colors - steps

MediaText - 3

  • Media Text block - Insert video from device (failing) - TC001-v
  • Media Text block - Close/Re-open post with an ongoing video upload - TC003-v

MediaText - 4

  • Media Text block - Media & Text alignment - TC006
  • Media Text block - Vertical alignment - TC007

Shortcode-1

  • Shortcode block - Add a youtube link - steps

Cover - 2

  • Cover - Add Video Background from WordPress Media library - TC005
  • Cover - Replace media - TC006
  • Cover - Gradient background is rendered properly - TC007
  • Cover - Gradient overlay is rendered properly - TC008

Social Icons - 2

  • The link sheet is opened automatically when adding new icon - TC004
  • Ghost placeholder is visible when no icon is active - TC005
  • Social icon forwarding to the link - TC006

Image - 2

  • Image block - Border style setting - TC006
  • Image block - Image size setting - TC007
  • Image block - Link to setting - TC008

Story block - 1

  • Story block - Verify is available in Block Picker - TC001
  • Story block - Verify is not available in Block Picker- TC002
  • Story block - Add media to empty Story block - TC003
  • Story block - Add media to non-empty Story block - TC004
  • Story block - Close/Re-open post with an ongoing Story upload - TC005

@SiobhyB
Copy link
Contributor Author

SiobhyB commented Nov 30, 2021 •
edited
Loading

🟢 Testing Changes (iOS)

Tested with build 18.8 on an iPhone XR (iOS 14.6).

@jd-alexander
Copy link
Contributor

jd-alexander commented Nov 30, 2021 •
edited
Loading

🔴 Writing Flow Test Cases (Android)

Tested with build 18.8 on a Google Pixel 4 XL (Android 12).

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

🔴 Issues Discovered

Heading block : split and merge causes empty paragaph and new lines during operation

@jd-alexander
Copy link
Contributor

jd-alexander commented Dec 1, 2021 •
edited
Loading

🟢 Test Suite 4 (Android)

Tested with build 18.8 on a Google Pixel 4 XL (Android 12).

DarkMode - 2

  • Spacer block - Dark mode - TC004
  • Buttons block - Dark mode - TC005
  • Group - Dark mode - TC006
  • Columns - Dark mode - TC007

Group - 2

  • Group - Navigation up button works as expected - TC009
  • Group - Navigation down works according to parent-first approach - TC010
  • Group - Cross navigation between blocks works as expected - TC011
  • Group - Ungroup button works as expected - TC012
  • Group - Check if in DarkMode all components gets proper colors - TC013
  • Group - Check if nested Placeholder block can be replaced - TC014

Spacer - 2

  • Spacer block - Settings: Available height range is correct - TC004
  • Spacer block - Settings: Height range extends if Spacer comes from the web is higher than 500px - TC005
  • Spacer block - Spacer in horizontal layout works as expected - TC006

Buttons - 4

  • Buttons block - Render custom text color - TC017
  • Buttons block - Render custom background color - TC016
  • Buttons block - Render gradient background color - TC018
  • Buttons block - Check if selection / caret color matches font color - TC020
  • Buttons block - The newly created Buttons has set background color to the theme-default color in preview - TC021

Buttons - 5

  • Buttons block - Edit text styles - TC009
  • Buttons block - Render theme colors - TC019
  • Buttons block - Settings: Change Button border radius - TC015

Buttons - 7

  • Buttons block - Link from the clipboard is automatically added into the empty URL field in link settings and button options - TC008
  • Buttons block - Toolbar link button is active when Button has link - TC022

Editor Theme - 2

  • Custom Gradients - Check that custom gradients load in the editor - TC004
  • Offline Support - TC005

Color Settings - 2

  • Pressing color swatch - TC004
  • Customize gradient color - TC005
  • Custom color picker - TC006

@jd-alexander
Copy link
Contributor

jd-alexander commented Dec 1, 2021 •
edited
Loading

🟢 Unsupported Block Tests (Android)

Tested with build 18.8 on a Google Pixel 4 XL (Android 12).

  • TC001 User can edit unsupported blocks on Simple WP.com sites
  • TC002 User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@jd-alexander
Copy link
Contributor

jd-alexander commented Dec 1, 2021 •
edited
Loading

🟢 Testing Changes (Android)

Tested with build 18.8 on a Google Pixel 4 XL (Android 12).

@jd-alexander jd-alexander mentioned this pull request Dec 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jd-alexander jd-alexander jd-alexander approved these changes

Assignees
No one assigned
Labels
release-process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SiobhyB @jd-alexander @jhnstn @fluiddot @dcalhoun @ttahmouch