Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Fix scroll update when typing in RichText component #4299

Merged
merged 4 commits into from
Nov 26, 2021
Merged

[iOS] Fix scroll update when typing in RichText component #4299

merged 4 commits into from
Nov 26, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Nov 26, 2021 •
edited
Loading

Gutenberg PR: WordPress/gutenberg#36914

Fixes #4069

To test:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added this to the 1.68.0 (18.9) milestone Nov 26, 2021
@fluiddot fluiddot self-assigned this Nov 26, 2021
@fluiddot fluiddot mentioned this pull request Nov 26, 2021
Merged
7 tasks
SiobhyB
SiobhyB approved these changes Nov 26, 2021
View reviewed changes
Copy link
Contributor

@SiobhyB SiobhyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#36914 (review).

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 26, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@fluiddot fluiddot added the [Type] Bug Something isn't working label Nov 26, 2021
@fluiddot fluiddot merged commit f24b86b into develop Nov 26, 2021
@fluiddot fluiddot deleted the fix/update-scroll-by-caret-position branch November 26, 2021 16:18
@fluiddot fluiddot restored the fix/update-scroll-by-caret-position branch November 26, 2021 16:31
@fluiddot fluiddot deleted the fix/update-scroll-by-caret-position branch November 26, 2021 16:31
@guarani guarani mentioned this pull request Dec 9, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiobhyB SiobhyB SiobhyB approved these changes

@antonis antonis Awaiting requested review from antonis

Assignees

@fluiddot fluiddot

Labels
[Type] Bug Something isn't working
Projects
None yet
Milestone
1.68.0 (18.9)
Development

Successfully merging this pull request may close these issues.

Editor Doesn't Scroll When Typing Text Into Paragraph Block on iOS
2 participants
@fluiddot @SiobhyB