Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] - Add waits to fix editor test flakiness #4687

Merged
merged 7 commits into from
Mar 29, 2022
Merged

[RNMobile] - Add waits to fix editor test flakiness #4687

merged 7 commits into from
Mar 29, 2022

Conversation

wpmobilebot
Copy link
Collaborator

Related PRs

Description

This PR is generated by version-toolkit to downstream the changes for gutenberg submodule.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 23, 2022 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@fluiddot fluiddot added the Testing Anything related to automated tests label Mar 25, 2022
@fluiddot fluiddot self-requested a review March 25, 2022 09:07
fluiddot
fluiddot approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#39668 (review).

NOTE: Before merging the Gutenberg reference should point to the merge commit of WordPress/gutenberg#39668.

@jostnes
Copy link
Contributor

jostnes commented Mar 29, 2022

Ah looks like I don't have the permission to merge this, can you help to merge this one @fluiddot? I've updated the Gutenberg reference to the merge commit of the Gutenberg PR: WordPress/gutenberg@c653bae

Thanks in advance 🙇‍♀️

@fluiddot fluiddot added this to the 1.73.0 milestone Mar 29, 2022
@fluiddot
Copy link
Contributor

Ah looks like I don't have the permission to merge this, can you help to merge this one @fluiddot? I've updated the Gutenberg reference to the merge commit of the Gutenberg PR: WordPress/gutenberg@c653bae

Thanks in advance 🙇‍♀️

Sure thing, I'll go ahead and merge the PR.

@hypest I'm wondering if we could give merge permission to @jostnes for future PRs related to E2E improvements, wdyt?

@fluiddot fluiddot merged commit 54fc739 into trunk Mar 29, 2022
@fluiddot fluiddot deleted the version-toolkit/gutenberg/rnmobile/editor-test-fixes branch March 29, 2022 08:01
@hypest
Copy link
Contributor

hypest commented Mar 29, 2022

@hypest I'm wondering if we could give merge permission to @jostnes for future PRs related to E2E improvements, wdyt?

Done!

@jostnes
Copy link
Contributor

jostnes commented Mar 29, 2022

Got the invite. Thank you both!

@geriux geriux mentioned this pull request Mar 31, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluiddot fluiddot fluiddot approved these changes

Assignees
No one assigned
Labels
Testing Anything related to automated tests
Projects
None yet
Milestone
1.73.0 (19.6)
Development

Successfully merging this pull request may close these issues.
4 participants
@wpmobilebot @jostnes @fluiddot @hypest