-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.76.3 #4922
Release 1.76.3 #4922
Conversation
🟢 New changes (iOS)Build: pr18813-fa073b8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎊 !
🟢 Writing Flow checklist (iOS)Build: pr18813-fa073b8 General
Rich Text Format
Splitting and merging
Undo / Redo - Test Cases |
🟢 Smoke testing (iOS)Build: pr18813-fa073b8
|
<string name="gutenberg_native_upgrade_your_plan_to_upload_audio" tools:ignore="UnusedResources">Upgrade your plan to upload audio</string> | ||
<string name="gutenberg_native_upgrade_your_plan_to_use_video_covers" tools:ignore="UnusedResources">Upgrade your plan to use video covers</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@geriux I'm curious why these strings were added in 1.77.0
and then removed in this PR 🤔 . As far as I checked, they come from Jetpack (reference) but I think they're not actually used in the editor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do they show up again in 1.77.1
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do they show up again in 1.77.1 ?
Yep, after running the command npm run bundle
, I see that these strings are re-introduced (reference).
I've checked this further and looks like the strings are expected to be here although they are not used. The file where they are defined (reference) it's being imported in a native file, hence as they're referenced, they're considered to be part of the editor and to be translated.
- These strings are defined in the function
usableBlockWithFreePlan
. usableBlockWithFreePlan
is used in the exported functionisStillUsableWithFreePlan
.isStillUsableWithFreePlan
is exported as part of the@automattic/jetpack-shared-extension-utils
package.- Package
@automattic/jetpack-shared-extension-utils
package is imported in the native fileregister-jetpack-block.native.native.js
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably, we haven't bumped into this change before because the Jetpack reference was recently updated, and a lot of time has passed since the last update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see I did encounter issues with the jetpack reference, I'm sure it's related. Sorry for that 😅
Release for Gutenberg Mobile 1.76.3
Related PRs
Gutenberg: Mobile Release v1.76.3 WordPress/gutenberg#41498
WPAndroid: N/A
WPiOS: Integrate gutenberg-mobile release 1.76.3 WordPress-iOS#18813
Aztec-iOS: N/A
Aztec-Android: N/A
Extra PRs that Landed After the Release Was Cut
No extra PRs yet. 🎉
Changes
Change 1
react-native-reanimated
version to2.4.1-wp-3
WordPress/gutenberg#41482Test plan
Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.
Release Submission Checklist
RELEASE-NOTES.txt
is updated with all the changes that made it to the release. ReplaceUnreleased
section with the release version and create a newUnreleased
section.gutenberg/packages/react-native-editor/CHANGELOG.md
is updated with all the changes that made it to the release. Replace## Unreleased
with the release version and create a new## Unreleased
.