Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.76.3 #4922

Merged
merged 17 commits into from
Jun 3, 2022
Merged

Release 1.76.3 #4922

merged 17 commits into from
Jun 3, 2022

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Jun 2, 2022

Release for Gutenberg Mobile 1.76.3

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Change 1

Test plan

Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

@geriux geriux marked this pull request as ready for review June 2, 2022 10:53
@geriux geriux requested a review from fluiddot June 2, 2022 10:54
@geriux
Copy link
Contributor Author

geriux commented Jun 2, 2022

Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊 !

@geriux
Copy link
Contributor Author

geriux commented Jun 2, 2022

🟢 Writing Flow checklist (iOS)

Build: pr18813-fa073b8
Device: iPhone 13 Pro (OS 15.5)

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@geriux
Copy link
Contributor Author

geriux commented Jun 2, 2022

🟢 Smoke testing (iOS)

Build: pr18813-fa073b8
Device: iPhone 13 Pro (OS 15.5)

  • Complete some overall smoke testing of the editor

@geriux geriux merged commit 6a70dc9 into trunk Jun 3, 2022
@geriux geriux deleted the release/1.76.3 branch June 3, 2022 09:28
Comment on lines -349 to -350
<string name="gutenberg_native_upgrade_your_plan_to_upload_audio" tools:ignore="UnusedResources">Upgrade your plan to upload audio</string>
<string name="gutenberg_native_upgrade_your_plan_to_use_video_covers" tools:ignore="UnusedResources">Upgrade your plan to use video covers</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geriux I'm curious why these strings were added in 1.77.0 and then removed in this PR 🤔 . As far as I checked, they come from Jetpack (reference) but I think they're not actually used in the editor.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do they show up again in 1.77.1 ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do they show up again in 1.77.1 ?

Yep, after running the command npm run bundle, I see that these strings are re-introduced (reference).

I've checked this further and looks like the strings are expected to be here although they are not used. The file where they are defined (reference) it's being imported in a native file, hence as they're referenced, they're considered to be part of the editor and to be translated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, we haven't bumped into this change before because the Jetpack reference was recently updated, and a lot of time has passed since the last update.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see I did encounter issues with the jetpack reference, I'm sure it's related. Sorry for that 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants