Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onImageFailedRetry interface #528

Merged
merged 29 commits into from
Feb 1, 2019
Merged

Add onImageFailedRetry interface #528

merged 29 commits into from
Feb 1, 2019

Conversation

mzorz
Copy link
Contributor

@mzorz mzorz commented Jan 30, 2019

This PR adds the failed / retry interface in the bridge (Android side).

We need the iOS side as well. @SergioEstevao

@mzorz
Copy link
Contributor Author

mzorz commented Jan 30, 2019

This one is ready for iOS to be added @SergioEstevao

@mzorz
Copy link
Contributor Author

mzorz commented Jan 31, 2019

@SergioEstevao added a way to clear an image block and unset it in WordPress/gutenberg#13610, referenced in this PR in commit 6f9b05f

Copy link
Contributor

@marecar3 marecar3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM regarding Android/Java code.

@mzorz mzorz merged commit bd20600 into develop Feb 1, 2019
@mzorz mzorz deleted the add/retry-failed-upload branch February 1, 2019 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants