Fix Image caption font family error on iOS #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hypest
approved these changes
Feb 6, 2019
…rg-mobile into issue/372-fix-image-caption-styling-error-ios * 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile: Update gutenberg ref to master Update gutenberg ref Update gutenberg ref Update Gutenberg-mobile bundle version in the app. Update gutenberg ref Update gutenberg ref Update gutenberg ref
daniloercoli
deleted the
issue/372-fix-image-caption-styling-error-ios
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an error on the
Imageblock where thefontFamilywas hard coded in the block, instead of reading it via CSS, and an error thrown on iOS since the family missing.GB-side PR: WordPress/gutenberg#13677
Note: remember to update the GB ref to point to
masterbefore the merge of this PR.