perf: Reduce inner blocks tree depth #5746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
…-depth' of github.com:wordpress-mobile/gutenberg-mobile into version-toolkit/gutenberg/perf/reduce-inner-blocks-tree-depth
|
@dcalhoun It looks like there's a visual test that keeps failing 🤔 |
The block list refactor modified the Xpath for this element.
Now that rich text fields can be selected without selecting the parent, the test query happened to select the Button block instead of the parent Buttons block. We now navigate upwards on Android to address this.
Android fails to display the keyboard at times, which can cause waiting for the keyboard to hide to finish prematurely.
…into version-toolkit/gutenberg/perf/reduce-inner-blocks-tree-depth
This was erroneously included during a merge conflict resolution.
|
@geriux CI tasks are now passing. 🎉 |
…into version-toolkit/gutenberg/perf/reduce-inner-blocks-tree-depth
…into version-toolkit/gutenberg/perf/reduce-inner-blocks-tree-depth
dcalhoun
deleted the
version-toolkit/gutenberg/perf/reduce-inner-blocks-tree-depth
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
Description
This PR is generated by
version-toolkitto downstream the changes forgutenbergsubmodule.