Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual tests - Adds testing nesting multiple Columns blocks #5815

Merged
merged 3 commits into from
May 30, 2023
Merged

Visual tests - Adds testing nesting multiple Columns blocks #5815

merged 3 commits into from
May 30, 2023

Conversation

geriux
Copy link
Contributor

@geriux geriux commented May 30, 2023 •
edited
Loading

Related PRs:

This PR adds a test related to nesting multiple Columns blocks, in the past we've encountered crashes nesting too many views. This should cover the manual testing we are currently doing.

To test CI checks should pass.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@geriux geriux added the Testing Anything related to automated tests label May 30, 2023
@geriux geriux mentioned this pull request May 30, 2023
Merged
@geriux geriux requested a review from dcalhoun May 30, 2023 13:59
@geriux geriux marked this pull request as ready for review May 30, 2023 14:00
@geriux geriux added this to the 1.97.0 (22.6) milestone May 30, 2023
dcalhoun
dcalhoun approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This great! Thank you for updating the tracking spreadsheet. 👏🏻

@geriux geriux mentioned this pull request May 30, 2023
Merged
@peril-wordpress-mobile
Copy link

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@geriux geriux merged commit 90d0683 into trunk May 30, 2023
@geriux geriux deleted the add/more-visual-tests branch May 30, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcalhoun dcalhoun dcalhoun approved these changes

Assignees
No one assigned
Labels
Testing Anything related to automated tests
Projects
None yet
Milestone
1.97.0 (22.6)
Development

Successfully merging this pull request may close these issues.
2 participants
@geriux @dcalhoun