Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.98.0 #5897

Merged
merged 7 commits into from
Jun 23, 2023
Merged

Release 1.98.0 #5897

merged 7 commits into from
Jun 23, 2023

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Jun 22, 2023 •
edited
Loading

Release for Gutenberg Mobile 1.98.0

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Change 1

Change 2

Test plan

Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

This was referenced Jun 22, 2023
Merged
Merged
Merged
dcalhoun
dcalhoun commented Jun 22, 2023
View reviewed changes
bundle/android/strings.xml
@@ -297,6 +297,7 @@ translators: %s: Select control button label e.g. "Button width" -->
<string name="gutenberg_native_replace_image_or_video" tools:ignore="UnusedResources">Replace image or video</string>
<string name="gutenberg_native_replace_video" tools:ignore="UnusedResources">Replace video</string>
<string name="gutenberg_native_retry" tools:ignore="UnusedResources">Retry</string>
<string name="gutenberg_native_reusable" tools:ignore="UnusedResources">Reusable</string>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addition results from merging WordPress/gutenberg#51144, but not yet WordPress/gutenberg#51704.

@dcalhoun dcalhoun marked this pull request as ready for review June 22, 2023 17:20
@geriux geriux self-requested a review June 22, 2023 17:46
geriux
geriux approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@dcalhoun dcalhoun added this to the 1.98.0 (22.7) milestone Jun 22, 2023
@dcalhoun dcalhoun enabled auto-merge June 23, 2023 11:34
@dcalhoun dcalhoun merged commit 5914a38 into trunk Jun 23, 2023
@dcalhoun dcalhoun deleted the release/1.98.0 branch June 23, 2023 13:00
@dcalhoun
Copy link
Member Author

dcalhoun commented Jun 27, 2023 •
edited
Loading

🟢 Release Changes (iOS)

Build: 22.7.0.0 (TestFlight)
Device: iPhone 13 mini (iOS 16.5.1)

@dcalhoun
Copy link
Member Author

dcalhoun commented Jun 27, 2023 •
edited
Loading

🔴 Writing Flow (iOS)

Build: 22.7.0.0 (TestFlight)
Device: iPhone 13 mini (iOS 16.5.1)

General

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@dcalhoun
Copy link
Member Author

dcalhoun commented Jun 27, 2023 •
edited
Loading

🟢 Unsupported Block Tests (iOS)

Build: 22.7.0.0 (TestFlight)
Device: iPhone 13 mini (iOS 16.5.1)

  • TC001 - User can edit unsupported blocks on Simple WP.com sites
  • TC002 - User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 - Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 - Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 - Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 - Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@dcalhoun
Copy link
Member Author

dcalhoun commented Jun 27, 2023 •
edited
Loading

🟢 Functionality Test Suite 4 (iOS)

Build: 22.7.0.0 (TestFlight)
Device: iPhone 13 mini (iOS 16.5.1)

DarkMode - 2

  • Spacer block - Dark mode - TC004
  • Buttons block - Dark mode - TC005
  • Group - Dark mode - TC006
  • Columns - Dark mode - TC007 Erroneous link to removed test case.

Group - 2

  • Group - Navigation up button works as expected - TC006
  • Group - Navigation down works according to parent-first approach - TC007 Outdated test case, now works with deepest-descendent-first approach.
  • Group - Cross navigation between blocks works as expected - TC008
  • Group - Check if in DarkMode all components gets proper colors - TC009
  • Group - Check if nested Placeholder block can be replaced - TC010

Buttons - 4

  • Buttons block - The newly created Buttons has set background color to the theme-default color in preview - TC017

Buttons - 5

  • Buttons block - Render theme colors - TC015
  • Buttons block - Settings: Change Button border radius - TC011

Buttons - 7

  • Buttons block - Toolbar link button is active when Button has link - TC018

Editor Theme - 2

  • Custom Gradients - Check that custom gradients load in the editor - TC004
  • Offline Support - TC005

Color Settings - 2

  • Pressing color swatch - TC004
  • Customize gradient color - TC005
  • Custom color picker - TC006

VideoPress - 1

  • VideoPress block - Upload a video - TC001
  • VideoPress block - Add Caption - TC002
  • VideoPress block - Close post with an ongoing video upload - TC004

@geriux
Copy link
Contributor

geriux commented Jun 28, 2023 •
edited
Loading

🟢 New changes (Android)

Build: 22.7-rc-1
Device: Galaxy A23 5G (Android 13)

@geriux
Copy link
Contributor

geriux commented Jun 28, 2023 •
edited
Loading

🔴 Writing Flow checklist (Android)

Build: 22.7-rc-1
Device: Galaxy A23 5G (Android 13)

General

🔴 Encountered WordPress/gutenberg#51996

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@geriux
Copy link
Contributor

geriux commented Jun 28, 2023 •
edited
Loading

🟢 Unsupported Block Tests (Android)

Build: 22.7-rc-1
Device: Galaxy A23 5G (Android 13)

  • TC001 - User can edit unsupported blocks on Simple WP.com sites
  • TC002 - User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 - Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 - Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 - Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 - Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@geriux
Copy link
Contributor

geriux commented Jun 28, 2023 •
edited
Loading

🟢 Functionality Tests - Test Suite 3 (Android)

Build: 22.7-rc-1
Device: Galaxy A23 5G (Android 13)

Gallery - 2

  • Gallery block - Insert image from device (failing) - TC006
  • Gallery block - Insert image from device (cancel) - TC009
  • Gallery block - Try adding same images from WP Media library and moving the images around - TC010

Gallery - 3

  • Gallery block - Settings: Link to - TC012
  • Gallery block - Settings: Column number - TC013
  • Gallery block - Settings: Crop images - TC014

MediaText - 3

  • Media Text block - Insert video from device (failing) - TC001-v
  • Media Text block - Close/Re-open post with an ongoing video upload - TC003-v

MediaText - 4

  • Media Text block - Media & Text alignment - TC006
  • Media Text block - Vertical alignment - TC007

Shortcode-1

  • Shortcode block - Add a youtube link - TC001

Cover - 2

  • Cover - Add Video Background from WordPress Media library - TC004
  • Cover - Replace media - TC005
  • Cover - Gradient background is rendered properly - TC006
  • Cover - Gradient overlay is rendered properly - TC007

Image - 2

  • Image block - Border style setting - TC006
  • Image block - Image size setting - TC007
  • Image block - Link to setting - TC008

Story block - 1

  • Story block - Verify is available in Block Picker - TC001
  • Story block - Verify is not available in Block Picker- TC002
  • Story block - Add media to empty Story block - TC003
  • Story block - Add media to non-empty Story block - TC004
  • Story block - Close/Re-open post with an ongoing Story upload - TC005

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriux geriux geriux approved these changes

Assignees
No one assigned
Labels
release-process
Projects
None yet
Milestone
1.98.0 (22.7)
Development

Successfully merging this pull request may close these issues.
2 participants
@dcalhoun @geriux