Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Voice Over and assistive keyboards #6102

Conversation

wpmobilebot
Copy link
Collaborator

@wpmobilebot wpmobilebot commented Aug 23, 2023

Related PRs:

Description

This PR addresses a regression after the React Native 0.71 upgrade, affecting how VoiceOver works with assistive input like Braille Screen Input, as well as using a Bluetooth keyboard and VoiceOver enabled.

For a better detailed description and test instructions please check the Gutenberg PR description.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 23, 2023

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@geriux geriux changed the title [Mobile] - AztecView - Replace usage of TouchableWithoutFeedback with Pressable Fix Voice Over and assistive keyboards Aug 23, 2023
@geriux geriux added the bugfix label Aug 23, 2023
@geriux geriux self-assigned this Aug 23, 2023
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#53895 (review). This is definitely worth adding a release note IMO.

@geriux geriux added this to the 1.103.0 (23.2) milestone Aug 24, 2023
@geriux geriux force-pushed the version-toolkit/gutenberg/rnmobile/fix-voice-over-assistive-keyboards branch from ba52c77 to 40babdd Compare August 24, 2023 17:08
@geriux
Copy link
Contributor

geriux commented Aug 24, 2023

Approved via WordPress/gutenberg#53895 (review). This is definitely worth adding a release note IMO.

As discussed in WordPress/gutenberg#53895 (comment) I'll avoid adding a release note to prevent possible conflicts when cherry-picking this change into the upcoming beta fix.

@geriux geriux merged commit da001eb into trunk Aug 24, 2023
@geriux geriux deleted the version-toolkit/gutenberg/rnmobile/fix-voice-over-assistive-keyboards branch August 24, 2023 18:05
@geriux geriux modified the milestones: 1.103.0 (23.2), 1.102.0 (23.1) Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants